cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14145) Resolve npm audit issues
Date Fri, 06 Jul 2018 23:37:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535480#comment-16535480
] 

ASF GitHub Bot commented on CB-14145:
-------------------------------------

brodybits edited a comment on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve
npm audit & other issues in patch release
URL: https://github.com/apache/cordova-android/pull/451#issuecomment-402448232
 
 
   I just pushed a complete rebase, with the following updates:
   - Update cordova.js from cordova-js@4.2.4 with the following _(using local coho with apache/cordova-coho#176
for patch release support)_:
     - CB-9366 log error.stack
   - update to cordova-common@2.2.5
   - pin other dependencies in package.json
   - completely reinstalled dependencies in `node_modules` using npm@6.1.0
   - update bundledDependencies in package.json, needed by the deprecated node 4 version
   - include changes that were added by @raphinesse (with PR number added to the commit messages
in the last 3 changes)
   
   tested in Cordova project using node 4 (deprecated) and node 8.
   
   _`npm audit` with npm@6.1.0 (latest release) shows 0 vulnerabilities_

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Resolve npm audit issues
> ------------------------
>
>                 Key: CB-14145
>                 URL: https://issues.apache.org/jira/browse/CB-14145
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android, cordova-app-hello-world, cordova-browser, cordova-cli,
cordova-coho, cordova-common, cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-plugman,
cordova-windows
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number of components
would report dependencies with security issues. While we could not see any {{npm audit}} issues
that may affect applications built using Cordova I think it is extremely important to resolve
these issues as soon as possible. Most affect devDependencies used for testing of Cordova
itself; a minority seem to affect Cordova scripts that may be run by Cordova application developers.
Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, {{cordova-lib}},
etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova platform implementations,
major plugins, etc. (expected to be fixed in minor release branch; do not want to pollute
the master branch with extra reverts, updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, which should
NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message