cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14145) Resolve npm audit issues
Date Fri, 06 Jul 2018 15:31:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534995#comment-16534995
] 

ASF GitHub Bot commented on CB-14145:
-------------------------------------

brodybits opened a new pull request #379: CB-14145 resolve npm audit issues in patch fix
URL: https://github.com/apache/cordova-ios/pull/379
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   iOS
   
   ### What does this PR do?
   
   - Set VERSION to 4.5.5-dev & update JS snapshot to version 4.5.5-dev via coho, using
local coho with apache/cordova-coho#176 for patch release support
   - updated dependencies in package.json to resolve `npm audit` issues in this patch fix:
      - cordova-common@2.2.5
      - ios-sim@6.1.3
      - plist@2.1.0
   - completely reinstall `node_modules` (ignoring `node_modules/.bin`) using the following
command on npm@6.1.0: `npm install --only=production`
   - Update `cordova.js` from cordova-js@4.2.4 with the following changes (using local coho
with apache/cordova-coho#176 for patch release support):
      - CB-9366 log error.stack
   - update `bundledDependencies` to support deprecated Node.js 4 in this patch fix
   - remove devDependencies not needed in this patch fix:
     - coffee-script
     - uncrustify
   - update `.travis.yml` to test on latest version of Node.js 4 (deprecated), 6, 8, and 10
(with other minor cleanup fixes)
   - minor `.gitignore` updates in this patch fix
   - update `appveyor.yml` to cover Node.js 8 & 10
   
   ### What testing has been done on this change?
   
   - Adding local cordova-ios with these changes to new Cordova project on deprecated Node.js
4 results in no ugly engine warning errors, project runs on iOS (11.4)
   - Adding local cordova-ios with these changes to new Cordova project on Node.js 8 results
in project that runs properly on iOS (11.4)
   - `npm run unit-tests` passes on full npm install on Node.js versions 4 (deprecated), 6,
8, and 10
   
   CI testing todo:
   - [ ] verify that `npm test` and other tests pass on Travis CI
   - [ ] verify that installation, `unit-tests`, etc. pass on AppVeyor CI
   
   ### Checklist
   
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. (with some
exceptions)
   - ~~Added automated test coverage as appropriate for this change.~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Resolve npm audit issues
> ------------------------
>
>                 Key: CB-14145
>                 URL: https://issues.apache.org/jira/browse/CB-14145
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android, cordova-app-hello-world, cordova-browser, cordova-cli,
cordova-coho, cordova-common, cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-plugman,
cordova-windows
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number of components
would report dependencies with security issues. While we could not see any {{npm audit}} issues
that may affect applications built using Cordova I think it is extremely important to resolve
these issues as soon as possible. Most affect devDependencies used for testing of Cordova
itself; a minority seem to affect Cordova scripts that may be run by Cordova application developers.
Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, {{cordova-lib}},
etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova platform implementations,
major plugins, etc. (expected to be fixed in minor release branch; do not want to pollute
the master branch with extra reverts, updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, which should
NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message