cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14145) Resolve npm audit issues
Date Mon, 09 Jul 2018 13:38:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536927#comment-16536927
] 

ASF GitHub Bot commented on CB-14145:
-------------------------------------

brodybits closed pull request #30: [CB-14145] npm audit in CI TEST WIP - DO NOT MERGE
URL: https://github.com/apache/cordova-common/pull/30
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index 459273a..ea52324 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,15 +1,25 @@
 language: node_js
 sudo: false
+
 git:
   depth: 10
+
 node_js:
-  - "4"
   - "6"
+  - "8"
+  - "10"
+
 install:
   - npm install
   - npm install -g codecov
+  - node --version
+  - npm --version
+
 script:
   - npm test
   - npm run cover
+  - npm install -g npm@latest
+  - npm audit
+
 after_script:
   - codecov
diff --git a/appveyor.yml b/appveyor.yml
index 94714f2..819578f 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -3,12 +3,15 @@
 
 environment:
   matrix:
-  - nodejs_version: "4"
   - nodejs_version: "6"
-  
+  - nodejs_version: "8"
+  - nodejs_version: "10"
+
 install:
   - ps: Install-Product node $env:nodejs_version
   - npm install
+  - node --version
+  - npm --version
 
 build: off
 
@@ -16,3 +19,5 @@ test_script:
   - node --version
   - npm --version
   - npm test
+  - npm install -g npm@latest
+  - npm audit
diff --git a/package.json b/package.json
index cd5fa09..ea5b7c7 100644
--- a/package.json
+++ b/package.json
@@ -3,7 +3,7 @@
   "name": "cordova-common",
   "description": "Apache Cordova tools and platforms shared routines",
   "license": "Apache-2.0",
-  "version": "2.1.1",
+  "version": "2.1.2-dev",
   "repository": {
     "type": "git",
     "url": "https://github.com/apache/cordova-lib"


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Resolve npm audit issues
> ------------------------
>
>                 Key: CB-14145
>                 URL: https://issues.apache.org/jira/browse/CB-14145
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android, cordova-app-hello-world, cordova-browser, cordova-cli,
cordova-coho, cordova-common, cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-plugman,
cordova-windows
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number of components
would report dependencies with security issues. While we could not see any {{npm audit}} issues
that may affect applications built using Cordova I think it is extremely important to resolve
these issues as soon as possible. Most affect devDependencies used for testing of Cordova
itself; a minority seem to affect Cordova scripts that may be run by Cordova application developers.
Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, {{cordova-lib}},
etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova platform implementations,
major plugins, etc. (expected to be fixed in minor release branch; do not want to pollute
the master branch with extra reverts, updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, which should
NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message