cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14145) Resolve npm audit issues
Date Mon, 09 Jul 2018 11:07:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536791#comment-16536791
] 

ASF GitHub Bot commented on CB-14145:
-------------------------------------

janpio edited a comment on issue #281: CB-14145 resolve npm audit issues in patch fix
URL: https://github.com/apache/cordova-windows/pull/281#issuecomment-403442584
 
 
   > pin other dependencies in package.json in this patch fix
   
   Why?
   
   > update bundledDependencies to support deprecated Node.js 4 in this patch fix
   
   Why are so many additional libraries now listed there?
   
   > Commit: .gitignore ignore package-lock.json in 6.0.x 
   
   was this somewhere decided to how Cordova should handle `package-lock.json`?
   
   > Commit: CB-14145 remove node_modules before patch fix
   
   Why?
   
   > Several commits: "... in 6.0.x"
   
   What does this mean? Won't these commits get merged to master as well?
   
   Is it correct that RELEASENOTES don't have a 6.0.1 entry here?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Resolve npm audit issues
> ------------------------
>
>                 Key: CB-14145
>                 URL: https://issues.apache.org/jira/browse/CB-14145
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android, cordova-app-hello-world, cordova-browser, cordova-cli,
cordova-coho, cordova-common, cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-plugman,
cordova-windows
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number of components
would report dependencies with security issues. While we could not see any {{npm audit}} issues
that may affect applications built using Cordova I think it is extremely important to resolve
these issues as soon as possible. Most affect devDependencies used for testing of Cordova
itself; a minority seem to affect Cordova scripts that may be run by Cordova application developers.
Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, {{cordova-lib}},
etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova platform implementations,
major plugins, etc. (expected to be fixed in minor release branch; do not want to pollute
the master branch with extra reverts, updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, which should
NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message