cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12018) Update tests to use jasmine instead of jasmine-node
Date Wed, 04 Jul 2018 23:38:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533128#comment-16533128
] 

ASF GitHub Bot commented on CB-12018:
-------------------------------------

raphinesse closed pull request #88: CB-12018 : updated tests to work with jasmine instead
of jasmine-node
URL: https://github.com/apache/cordova-plugman/pull/88
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/package.json b/package.json
index 9f438d2..cf2d3fd 100644
--- a/package.json
+++ b/package.json
@@ -1,72 +1,73 @@
 {
-    "author": "Andrew Lunny <alunny@gmail.com>",
-    "name": "plugman",
-    "description": "install/uninstall Cordova plugins",
-    "version": "1.4.1-dev",
-    "repository": {
-        "type": "git",
-        "url": "git://git-wip-us.apache.org/repos/asf/cordova-plugman.git"
+  "author": "Andrew Lunny <alunny@gmail.com>",
+  "name": "plugman",
+  "description": "install/uninstall Cordova plugins",
+  "version": "1.4.1-dev",
+  "repository": {
+    "type": "git",
+    "url": "git://git-wip-us.apache.org/repos/asf/cordova-plugman.git"
+  },
+  "bugs": {
+    "url": "https://issues.apache.org/jira/browse/CB",
+    "email": "dev@cordova.apache.org"
+  },
+  "main": "plugman.js",
+  "engines": {
+    "node": ">=0.9.9"
+  },
+  "engineStrict": true,
+  "dependencies": {
+    "cordova-lib": "6.4.0",
+    "jasmine": "^2.5.3",
+    "nopt": "1.0.9",
+    "q": "1.0.1"
+  },
+  "devDependencies": {
+    "jshint": "2.5.8",
+    "jasmine": "2.5.3"
+  },
+  "bin": {
+    "plugman": "./main.js"
+  },
+  "scripts": {
+    "test": "npm run jasmine && jshint",
+    "jshint": "jshint src",
+    "jasmine": "jasmine --captureExceptions --color"
+  },
+  "license": "Apache-2.0",
+  "contributors": [
+    {
+      "name": "Anis Kadri"
     },
-    "bugs": {
-        "url": "https://issues.apache.org/jira/browse/CB",
-        "email": "dev@cordova.apache.org"
+    {
+      "name": "Tim Kim"
     },
-    "main": "plugman.js",
-    "engines": {
-        "node": ">=0.9.9"
+    {
+      "name": "Braden Shepherdson"
     },
-    "engineStrict": true,
-    "dependencies": {
-        "cordova-lib": "6.4.0",
-        "nopt": "1.0.9",
-        "q": "1.0.1"
+    {
+      "name": "Ryan Willoughby"
     },
-    "devDependencies": {
-        "jshint": "2.5.8",
-        "jasmine-node": "1.14.5"
+    {
+      "name": "Brett Rudd"
     },
-    "bin": {
-        "plugman": "./main.js"
+    {
+      "name": "Mike Reinstein"
     },
-    "scripts": {
-        "test": "npm run jasmine && npm run jshint",
-        "jshint": "node node_modules/jshint/bin/jshint src",
-        "jasmine": "jasmine-node --captureExceptions --color spec"
+    {
+      "name": "Shazron Abdullah"
     },
-    "license": "Apache-2.0",
-    "contributors": [
-        {
-            "name": "Anis Kadri"
-        },
-        {
-            "name": "Tim Kim"
-        },
-        {
-            "name": "Braden Shepherdson"
-        },
-        {
-            "name": "Ryan Willoughby"
-        },
-        {
-            "name": "Brett Rudd"
-        },
-        {
-            "name": "Mike Reinstein"
-        },
-        {
-            "name": "Shazron Abdullah"
-        },
-        {
-            "name": "Steve Gill"
-        },
-        {
-            "name": "Fil Maj"
-        },
-        {
-            "name": "Michael Brooks"
-        },
-        {
-            "name": "Jesse MacFadyen"
-        }
-    ]
+    {
+      "name": "Steve Gill"
+    },
+    {
+      "name": "Fil Maj"
+    },
+    {
+      "name": "Michael Brooks"
+    },
+    {
+      "name": "Jesse MacFadyen"
+    }
+  ]
 }
diff --git a/spec/support/jasmine.json b/spec/support/jasmine.json
new file mode 100644
index 0000000..0bf271b
--- /dev/null
+++ b/spec/support/jasmine.json
@@ -0,0 +1,8 @@
+{
+    "spec_dir": "spec",
+    "spec_files": [
+        "**/*[sS]pec.js"
+    ],
+    "stopSpecOnExpectationFailure": false,
+    "random": false
+}


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Update tests to use jasmine instead of jasmine-node
> ---------------------------------------------------
>
>                 Key: CB-12018
>                 URL: https://issues.apache.org/jira/browse/CB-12018
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-android, cordova-cli, cordova-common, cordova-ios, cordova-js,
cordova-lib, cordova-plugman
>            Reporter: Steve Gill
>            Assignee: Audrey So
>            Priority: Major
>              Labels: cordova-7.0.0
>             Fix For: cordova@7.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message