From issues-return-94850-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Sun Jun 3 19:52:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E4E9E180600 for ; Sun, 3 Jun 2018 19:52:05 +0200 (CEST) Received: (qmail 7578 invoked by uid 500); 3 Jun 2018 17:52:05 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 7567 invoked by uid 99); 3 Jun 2018 17:52:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jun 2018 17:52:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 76A0D1A0490 for ; Sun, 3 Jun 2018 17:52:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Ud2dh-v-ExGj for ; Sun, 3 Jun 2018 17:52:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 743B35F3B7 for ; Sun, 3 Jun 2018 17:52:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 20A2AE0CCD for ; Sun, 3 Jun 2018 17:52:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3CB9921097 for ; Sun, 3 Jun 2018 17:52:00 +0000 (UTC) Date: Sun, 3 Jun 2018 17:52:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-12397) .gitignore fix MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-12397?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164995= 02#comment-16499502 ]=20 ASF GitHub Bot commented on CB-12397: ------------------------------------- brodybits opened a new pull request #8: CB-12397 fix .gitignore for plugins= & platforms (cordova-create part) URL: https://github.com/apache/cordova-create/pull/8 =20 =20 =20 ### Platforms affected =20 All =20 ### What does this PR do? =20 Workaround for [Apache Cordova CB-12397](https://issues.apache.org/jira/= browse/CB-12397): include .gitignore from `template_src` subdirectory of `c= ordova-app-hello-world`, needed due to the npm .gitignore/.npmignore behavi= or discussed in: - npm/npm#1862 - npm/npm#3763 - npm/npm#7252 =20 NOTE: Another part of the fix for [Apache Cordova CB-12397](https://iss= ues.apache.org/jira/browse/CB-12397) is in , to be raised after this PR. =20 Additional commits: - cleanup: remove trailing whitespace - general updates to test suite =20 ### What testing has been done on this change? =20 #### Unit test =20 Test suite updated to verify that `.gitignore` is included in the genera= ted app when the standard `cordova-app-hello-world` template is used. =20 #### Cordova CLI test =20 - Using `cordova-cli` test version in which uses local test installation of `cord= ova-lib` from due to limitations discussed in npm/npm#2974. - `cordova-lib` in references `cordova-create` in which includes this fix. - `cordova-create` in references `cordova-app-hello-world` in which include= s the `cordova-app-hello-world` fix in . =20 **Testing with results and other output on Windows:** =20 ``` C:\Users\Chris\Documents\chris-work\cb-12397-dev =CE=BB npm install -g https://github.com/brodybits/cordova-cli#cb-12397-= devtest1 npm WARN deprecated node-uuid@1.4.8: Use uuid module instead C:\Users\Chris\nvs\node\7.10.0\x64\cordova -> C:\Users\Chris\nvs\node\7.= 10.0\x64\node_modules\cordova\bin\cordova C:\Users\Chris\nvs\node\7.10.0\x64 `-- cordova@7.0.2-cb-12397-devtest1 (git+https://github.com/brodybits/c= ordova-cli.git#9f4648d5565b098434187aa3da251beca8d68dae) [...] C:\Users\Chris\Documents\chris-work\cb-12397-dev =CE=BB cordova --version 7.0.2-cb-12397-devtest1 =20 C:\Users\Chris\Documents\chris-work\cb-12397-dev =CE=BB cordova create cb-12397-testapp1 Creating a new cordova project. =20 C:\Users\Chris\Documents\chris-work\cb-12397-dev =CE=BB ls -a !$ History expansion: ls -a cb-12397-testapp1 ./ ../ .gitignore .npmignore config.xml hooks/ package.json platf= orms/ plugins/ res/ www/ =20 C:\Users\Chris\Documents\chris-work\cb-12397-dev =CE=BB cat cb-12397-testapp1\.gitignore # macOS .DS_Store =20 # Generated by Cordova plugins platforms =20 C:\Users\Chris\Documents\chris-work\cb-12397-dev =CE=BB ``` =20 `.gitignore` is now present in the generated app, with `plugins` and `pl= atforms` as needed =20 ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.ht= ml) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug wit= h resolving file paths", where CB-xxxx is the JIRA ID & "android" is the pl= atform affected. - [x] Added automated test coverage as appropriate for this change. =20 =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > .gitignore fix > -------------- > > Key: CB-12397 > URL: https://issues.apache.org/jira/browse/CB-12397 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-app-hello-world, cordova-cli, cordova-create= , cordova-lib > Reporter: Chris Brody > Priority: Major > Labels: backlog, easy-fix > > Followup to CB-12008 (autosave by default in cordova@7): if a user create= s an app using "cordova create" there should be a .gitignore file to exclud= e the plugins and platforms artifacts from git. > I raise this since I have seen way too many apps with outdated plugins / = platforms artifacts included in git. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org