cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Darryl Pogue (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CB-13979) getEditConfigs() and getConfigFiles() only work for the first <platform> tag
Date Mon, 04 Jun 2018 21:29:00 GMT

     [ https://issues.apache.org/jira/browse/CB-13979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Darryl Pogue updated CB-13979:
------------------------------
    Fix Version/s: cordova-common@2.2.3

> getEditConfigs() and getConfigFiles() only work for the first <platform> tag
> ----------------------------------------------------------------------------
>
>                 Key: CB-13979
>                 URL: https://issues.apache.org/jira/browse/CB-13979
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-common
>    Affects Versions: Master
>            Reporter: Kevin Christopher Henry
>            Assignee: Darryl Pogue
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: cordova-common@2.2.3
>
>
> I ran into something strange - my configuration would change based on the ordering of
elements in config.xml.
> Looking at the source code, the culprit is getEditConfigs() and getConfigFiles() in ConfigParser.js.
Unlike the rest of the code they only look in the first platform tag for config directives:
> {{var platform_tag = this.doc.find('./platform[@name="' + platform + '"]');}}
> {{var platform_edit_configs = platform_tag ? platform_tag.findall('edit-config') : [];}}
> This should probably be something like this instead (untested):
> {{var platform_edit_configs = this.doc.findall('./platform[@name="' + platform + '"]/edit-config');}}
> And similarly for getConfigFiles().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message