cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12397) .gitignore fix
Date Sun, 03 Jun 2018 18:03:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499508#comment-16499508
] 

ASF GitHub Bot commented on CB-12397:
-------------------------------------

brodybits commented on issue #8: CB-12397 fix .gitignore for plugins & platforms (cordova-create
part)
URL: https://github.com/apache/cordova-create/pull/8#issuecomment-394179821
 
 
   @raphinesse got it. I hope it will check for presence vs absence of both `.gitignore` and
`.npmignore`, like I had proposed in f4b752d0224f76da8c9204412c8d2af590664994.
   
   Rationale: there are cases reproduced in f4b752d0224f76da8c9204412c8d2af590664994 where
`cordova-create` does create unwanted `.npmignore` file, due to the way `cordova-create` uses
NPM to consume the `cordova-app-hello-world` dependency. I think we want the actual behavior
to be known today and verified fixed for good in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> .gitignore fix
> --------------
>
>                 Key: CB-12397
>                 URL: https://issues.apache.org/jira/browse/CB-12397
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-app-hello-world, cordova-cli, cordova-create, cordova-lib
>            Reporter: Chris Brody
>            Priority: Major
>              Labels: backlog, easy-fix
>
> Followup to CB-12008 (autosave by default in cordova@7): if a user creates an app using
"cordova create" there should be a .gitignore file to exclude the plugins and platforms artifacts
from git.
> I raise this since I have seen way too many apps with outdated plugins / platforms artifacts
included in git.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message