cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12397) .gitignore fix
Date Fri, 01 Jun 2018 08:36:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497727#comment-16497727
] 

ASF GitHub Bot commented on CB-12397:
-------------------------------------

raphinesse commented on issue #8: CB-12397 fix .gitignore for plugins & platforms (cordova-create
part)
URL: https://github.com/apache/cordova-create/pull/8#issuecomment-393810234
 
 
   Yes, the current logic is pretty convoluted. Most of it is not documented either, AFAIK.
I proposed to simplify much of it in apache/cordova-discuss#89 which also outlines some of
the current logic.
   
   For the reasons mentioned in apache/cordova-discuss#69 I do not support the "hacky" solution
proposed by you. I rather hope that we can land some changes from apache/cordova-discuss#89
and build an easy and clean solution on top of the simplified cordova-create base.
   
   And I think #14 is still fine, even if this change here is delayed a bit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> .gitignore fix
> --------------
>
>                 Key: CB-12397
>                 URL: https://issues.apache.org/jira/browse/CB-12397
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-app-hello-world, cordova-cli, cordova-create, cordova-lib
>            Reporter: Chris Brody
>            Priority: Major
>              Labels: backlog, easy-fix
>
> Followup to CB-12008 (autosave by default in cordova@7): if a user creates an app using
"cordova create" there should be a .gitignore file to exclude the plugins and platforms artifacts
from git.
> I raise this since I have seen way too many apps with outdated plugins / platforms artifacts
included in git.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message