From issues-return-94533-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Wed May 16 11:54:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 31854180669 for ; Wed, 16 May 2018 11:54:07 +0200 (CEST) Received: (qmail 36793 invoked by uid 500); 16 May 2018 09:54:05 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 36738 invoked by uid 99); 16 May 2018 09:54:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2018 09:54:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CC34F18034E for ; Wed, 16 May 2018 09:54:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Lk3wP8Ewe3LQ for ; Wed, 16 May 2018 09:54:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 214665F3F4 for ; Wed, 16 May 2018 09:54:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BB0FAE02ED for ; Wed, 16 May 2018 09:54:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2FD37217A1 for ; Wed, 16 May 2018 09:54:00 +0000 (UTC) Date: Wed, 16 May 2018 09:54:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-14061) cordova-plugin-inappbrowser should allow more custom URL schemes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-14061?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164771= 87#comment-16477187 ]=20 ASF GitHub Bot commented on CB-14061: ------------------------------------- timbru31 commented on issue #269: CB-14061: (android) comply with RFC 3986 = for custom URL scheme handling URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/269#issueco= mment-389462693 =20 =20 Travis failure (https://travis-ci.org/apache/cordova-plugin-inappbrowser= /jobs/374068004) seems unrelated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > cordova-plugin-inappbrowser should allow more custom URL schemes > ---------------------------------------------------------------- > > Key: CB-14061 > URL: https://issues.apache.org/jira/browse/CB-14061 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Affects Versions: 3.0.0 > Reporter: Tim Brust > Priority: Minor > > The current Android regexp (^[a-z]*://.*?$) (https://github.com/apache/co= rdova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L1115) = does not allow schemes like d2d or develop+d2d. > According to RFC 3986 (quoting) "Scheme names consist of a sequence of ch= aracters beginning with a letter and followed by any combination of letters= , digits, plus ("+"), period ("."), or hyphen ("-")" (https://tools.ietf.or= g/html/rfc3986#section-3.1) > =C2=A0 > The regexp should be expanded to allow numbers, plus,=C2=A0periods and hy= phens. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org