From issues-return-93347-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Tue Mar 13 12:33:11 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CD22618067B for ; Tue, 13 Mar 2018 12:33:10 +0100 (CET) Received: (qmail 38368 invoked by uid 500); 13 Mar 2018 11:33:04 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 38234 invoked by uid 99); 13 Mar 2018 11:33:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Mar 2018 11:33:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5ACF5C5DE2 for ; Tue, 13 Mar 2018 11:33:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iIoKzi4NfI2M for ; Tue, 13 Mar 2018 11:33:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 71B245FB58 for ; Tue, 13 Mar 2018 11:33:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1CF00E0CEB for ; Tue, 13 Mar 2018 11:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3F66E21481 for ; Tue, 13 Mar 2018 11:33:00 +0000 (UTC) Date: Tue, 13 Mar 2018 11:33:00 +0000 (UTC) From: =?utf-8?Q?Steinar_=C3=81g=C3=BAst_Steinarsson_=28JIRA=29?= To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CB-13969) Allow close button and navigation buttons positions to be swapped - Cordova/inappbrowser MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-13969?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] Steinar =C3=81g=C3=BAst Steinarsson updated CB-13969: ------------------------------------------- Description:=20 Allow the user to swap positions for the close button and navigation button= s. I added a new property 'lefttoright' which does this. Screenshots: iOS(the default for the close button is being on the left): 'lefttoright' is set: !IMG_0004.PNG! default(not set): !IMG_0003.jpg! =C2=A0 Android(default is for close button being on the right): 'lefttoright' is set: !Screenshot_20180313-110504.png! default(not set): !Screenshot_20180313-105154.png! =C2=A0 I also fixed a bug in iOS which was hiding the navigation buttons, even tho= ugh 'hidenavigationbuttons' is false. was: Allow the user to swap positions for the close button and navigation button= s. I added a new property 'lefttoright' which does this. Screenshots: iOS(the default for the close button is being on the left): 'lefttoright' is set: !IMG_0004.PNG! default(not set): !IMG_0003.jpg! =C2=A0 Android(default is for close button being on the right): 'lefttoright' is set: !Screenshot_20180313-110504.png! default(not set): !Screenshot_20180313-105154.png! =C2=A0 I also fixed a bug in ios which was hiding the navigation buttons, even tho= ugh 'hidenavigationbuttons' is false. > Allow close button and navigation buttons positions to be swapped - Cordo= va/inappbrowser > -------------------------------------------------------------------------= --------------- > > Key: CB-13969 > URL: https://issues.apache.org/jira/browse/CB-13969 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS and Android > Reporter: Steinar =C3=81g=C3=BAst Steinarsson > Priority: Minor > Labels: inappbrowser > Attachments: IMG_0003.jpg, IMG_0004.PNG, Screenshot_20180313-1051= 54.png, Screenshot_20180313-110504.png > > Original Estimate: 0h > Remaining Estimate: 0h > > Allow the user to swap positions for the close button and navigation butt= ons. I added a new property 'lefttoright' which does this. > Screenshots: > iOS(the default for the close button is being on the left): > 'lefttoright' is set: > !IMG_0004.PNG! > default(not set): > !IMG_0003.jpg! > =C2=A0 > Android(default is for close button being on the right): > 'lefttoright' is set: > !Screenshot_20180313-110504.png! > default(not set): > !Screenshot_20180313-105154.png! =C2=A0 > I also fixed a bug in iOS which was hiding the navigation buttons, even t= hough 'hidenavigationbuttons' is false. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org