From issues-return-93248-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Tue Mar 6 10:16:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E3C98180652 for ; Tue, 6 Mar 2018 10:16:04 +0100 (CET) Received: (qmail 96208 invoked by uid 500); 6 Mar 2018 09:16:03 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 96197 invoked by uid 99); 6 Mar 2018 09:16:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2018 09:16:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 260E7180033 for ; Tue, 6 Mar 2018 09:16:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3o2HN3CAHztN for ; Tue, 6 Mar 2018 09:16:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9A9B05F475 for ; Tue, 6 Mar 2018 09:16:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 14956E021F for ; Tue, 6 Mar 2018 09:16:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 53DD321273 for ; Tue, 6 Mar 2018 09:16:00 +0000 (UTC) Date: Tue, 6 Mar 2018 09:16:00 +0000 (UTC) From: "armin (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-13953) Cordova has a hard dependency on Gradle being on the path and JAVA_HOME being set in advance MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-13953?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D163874= 92#comment-16387492 ]=20 armin commented on CB-13953: ---------------------------- [~bowserj], you do not need to commit in the wrapper, you can allow the cor= dova users to do it (optionally) so we are not forced to have gradle availa= ble on the path on every machine=C2=A0(including automated environments) an= d rely on the built-in configuration. This is about 5 lines of code to fix = for the ability to drop an unnecessary dependency and allow users to custom= ize wrapper generation, I really do not understand the quick decision to cl= ose the ticket. > Cordova has a hard dependency on Gradle being on the path and JAVA_HOME b= eing set in advance > -------------------------------------------------------------------------= ------------------- > > Key: CB-13953 > URL: https://issues.apache.org/jira/browse/CB-13953 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android > Affects Versions: cordova-android-7.0.0 > Environment: android build > Reporter: armin > Assignee: Joe Bowser > Priority: Minor > Original Estimate: 8h > Remaining Estimate: 8h > > Cordova is tightly coupled with the gradle executable and it is verifying= it being on the path even though the gradle wrapper is available. Also the= JAVA_HOME has to be already available or java be on the path before runnin= g cordova commands even though these can be set during the build. > In general there are several problems with the current gradle bootstrappi= ng process: > * Cordova checks for gradle being on the path and fails execution if it = isn't there even though the wrapper is already generated so gradle is not n= eeded at that point. The wrapper files are also on .gitignore for no reason= since committing them is fairly standard practice and they could be bundle= d with cordova from the beginning to avoid dependency on gradle in general = and to tie the gradle version to the cordova version. > * In general the checks inside cordova are not sufficient to determine i= f a given "requirement" is available (or will be set during the build) or n= ot, it should be possible to continue the build even if the build-in requir= ement checks fail > * The gradle wrapper is generated by Cordova instead of the user as it s= hould be and as it is the gradle convention -> this means any customization= process is extremely difficult and we have no control. It is understandabl= e to tie the gradle version to a cordova version but this version check sho= uld be done during execution and not before so the users can manage their o= wn wrapper > * Cordova is using a separate gradle file for generating the wrapper and= not the actual build.gradle file -> wrapper.gradle is being used for gener= ation which means any configuration from build.gradle is not respected, suc= h as wrapper version or wrapper customization (for example we also generate= the JAVA_HOME variable into the wrapper so we would not need java or gradl= e on the path at all after the initial install, as we only have a local ins= tallations) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org