cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13994) Cordova plugins pages dont show up properly while running cordova website locally using make
Date Wed, 21 Mar 2018 12:26:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407817#comment-16407817
] 

ASF GitHub Bot commented on CB-13994:
-------------------------------------

janpio closed pull request #807: CB-13994  Cordova plugins pages dont show up properly while
running cordova website locally using make
URL: https://github.com/apache/cordova-docs/pull/807
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/Makefile b/Makefile
index 43e95a229..23a2fa90d 100644
--- a/Makefile
+++ b/Makefile
@@ -238,7 +238,7 @@ $(FETCHED_FILES): $(FETCH_CONFIG) $(FETCH_SCRIPT)
 $(PLUGINS_APP): $(PLUGINS_SRC)
 	echo ---> $@
 	echo --->> $@
-	$(BROWSERIFY) -t reactify -t envify $< | $(UGLIFY) >> $@
+	$(BROWSERIFY) -t [ babelify --presets [ react ] --plugins [ transform-h-jsx ] ] -t envify
$< | $(UGLIFY) >> $@
 
 $(DOCS_VERSION_DATA): $(BIN_DIR)/gen_versions.js $(DOCS_DIR)
 	$(NODE) $(BIN_DIR)/gen_versions.js $(DOCS_DIR) > $@
diff --git a/package.json b/package.json
index 33cdbee30..82c662de4 100644
--- a/package.json
+++ b/package.json
@@ -50,7 +50,7 @@
     "preact-compat": "^3.17.0",
     "q": "^1.4.1",
     "shelljs": "^0.3.0",
-    "uglifyjs": "^2.4.10",
+    "uglify-js": "^3.3.15",
     "vinyl-buffer": "^1.0.0",
     "vinyl-source-stream": "^1.1.0",
     "walk": "^2.3.9",
@@ -58,6 +58,8 @@
   },
   "devDependencies": {
     "babel-plugin-transform-react-jsx": "^6.24.1",
+    "babel-plugin-transform-h-jsx": "^1.0.0",
+    "esutils": "^2.0.2",
     "babel-preset-react": "^6.24.1",
     "babelify": "^7.3.0",
     "colors": "^1.0.3",


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Cordova plugins pages dont show up properly while running cordova website locally using
make
> --------------------------------------------------------------------------------------------
>
>                 Key: CB-13994
>                 URL: https://issues.apache.org/jira/browse/CB-13994
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-docs
>            Reporter: Gandhirajan
>            Priority: Critical
>
> If cordova website is built and run locally using Makefile, Plugins page wont get rendered
properly. The plugins list and platforms options are not loaded. Basically the plugins page
is broken for make build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message