cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13960) Typescript: FileWriter write argument definition shall include type string
Date Thu, 08 Mar 2018 17:53:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391626#comment-16391626
] 

ASF GitHub Bot commented on CB-13960:
-------------------------------------

vldmr-bus opened a new pull request #231: CB-13960: fix FileWriter.write argument type definition
for typescript
URL: https://github.com/apache/cordova-plugin-file/pull/231
 
 
   Fix FileWriter.write argument type definition for typescript
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Typescript: FileWriter write argument definition shall include type string
> --------------------------------------------------------------------------
>
>                 Key: CB-13960
>                 URL: https://issues.apache.org/jira/browse/CB-13960
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-file
>            Reporter: Vladimir
>            Priority: Major
>
> www\FileWriter.js has the following annotation on write method:
> {code:java}
> @param data text or blob to be writte{code}
> But types\index.d.ts has the following type definition:
> {code:java}
>     /**
>      * Write the supplied data to the file at position.
>      * @param {Blob} data The blob to write.
>      */
>     write(data: Blob): void;{code}
> Shall be as follows:
> {code:java}
>     /**
>      * Write the supplied data to the file at position.
>      * @param {Blob|string} data The blob to write.
>      */
>     write(data: Blob|string): void;{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message