cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13948) Apps with ampersand (&) in the name throw build error in cordova-ios@4.3.1
Date Mon, 05 Mar 2018 02:18:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385494#comment-16385494
] 

ASF GitHub Bot commented on CB-13948:
-------------------------------------

codecov-io commented on issue #362: CB-13948 Properly encode app name to generate XML files
using cordova-ios 4.3.1
URL: https://github.com/apache/cordova-ios/pull/362#issuecomment-370291222
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/362?src=pr&el=h1) Report
   > Merging [#362](https://codecov.io/gh/apache/cordova-ios/pull/362?src=pr&el=desc)
into [4.3.x](https://codecov.io/gh/apache/cordova-ios/commit/8fe24d41b02e17eef6e232d1b907e2f97d0b87bd?src=pr&el=desc)
will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/362/graphs/tree.svg?height=150&width=650&token=WomDD5jInz&src=pr)](https://codecov.io/gh/apache/cordova-ios/pull/362?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##            4.3.x     #362   +/-   ##
   =======================================
     Coverage   64.11%   64.11%           
   =======================================
     Files          12       12           
     Lines        1360     1360           
     Branches      229      229           
   =======================================
     Hits          872      872           
     Misses        488      488
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/362?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/362?src=pr&el=footer).
Last update [8fe24d4...924b34c](https://codecov.io/gh/apache/cordova-ios/pull/362?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Apps with ampersand (&) in the name throw build error in cordova-ios@4.3.1
> --------------------------------------------------------------------------
>
>                 Key: CB-13948
>                 URL: https://issues.apache.org/jira/browse/CB-13948
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-ios
>    Affects Versions: 4.3.1
>            Reporter: Ronaldo Zanoni
>            Assignee: Suraj Pindoria
>            Priority: Major
>
> Cordova apps with an ampersand in the name give a build error in cordova-ios 4.3.1:
> "xcodebuild: error: Unable to load workspace 'Tom & Jerry.xcworkspace'.
> Reason: Could not open workspace file at ~/git/Tom & Jerry/platforms/ios/Tom &
Jerry.xcworkspace/contents.xcworkspacedata"
> I found that the problem is with the .xcworkspace file. The ampersand doesn't get encoded
in the XML files that are generated.
> PR that created the problem: [https://github.com/apache/cordova-ios/pull/247]
> Reproduce:
> 1. run cordova create HelloCordova
> 2. edit config.xml <name> tag inside to "Tom & Jerry"
> 3. run cordova platform add ios@4.3.1
> 4. run cordova build ios 
> --> ERROR
> *NOTE*: This was fixed in the _cordova-ios 4.4.0_, but that version has removed the _IOS
8_ support and we need that support yet.
> So, the solution is merge the branch _origin/4.3.x_ with this pull request: [https://github.com/apache/cordova-ios/pull/288]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message