cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
Date Tue, 06 Mar 2018 05:52:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387331#comment-16387331
] 

ASF GitHub Bot commented on CB-13415:
-------------------------------------

alsorokin commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera
plugin crashes the app
URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-370671665
 
 
   There's still one test failure, is it expected?
   ```
   Test Case '-[CameraTest testProcessImage]' started.
   2018-02-28 14:10:55.751 xctest[2330:8469] -[CDVCamera processImage:info:options:]: unrecognized
selector sent to instance 0x7976c770
   /Users/travis/build/apache/cordova-plugin-camera/tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m:481:
error: -[CameraTest testProcessImage] : failed: caught "NSInvalidArgumentException", "-[CDVCamera
processImage:info:options:]: unrecognized selector sent to instance 0x7976c770"
   (
   	0   CoreFoundation                      0x00c96ded __exceptionPreprocess + 189
   	1   libobjc.A.dylib                     0x00761d6f objc_exception_throw + 49
   	2   CoreFoundation                      0x00d085b8 -[NSObject(NSObject) doesNotRecognizeSelector:]
+ 136
   	3   CoreFoundation                      0x00c1ca8d ___forwarding___ + 941
   	4   CoreFoundation                      0x00c1c6be _CF_forwarding_prep_0 + 14
   	5   CDVCameraLibTests                   0x0edb4568 -[CameraTest testProcessImage] + 648
   	6   CoreFoundation                      0x00c1df4d __invoking___ + 29
   	7   CoreFoundation                      0x00c1de81 -[NSInvocation invoke] + 321
   	8   XCTest                              0x0066442b __24-[XCTestCase invokeTest]_block_invoke_2
+ 502
   	9   XCTest                              0x006a4b0a -[XCTestContext performInScope:] +
229
   	10  XCTest                              0x00664228 -[XCTestCase invokeTest] + 259
   	11  XCTest                              0x00664bc5 -[XCTestCase performTest:] + 621
   	12  XCTest                              0x006949b7 -[XCTest runTest] + 45
   	13  XCTest                              0x00661a39 __27-[XCTestSuite performTest:]_block_invoke
+ 258
   	14  XCTest                              0x0066160b -[XCTestSuite _performProtectedSectionForTest:testSection:]
+ 32
   	15  XCTest                              0x0066181b -[XCTestSuite performTest:] + 213
   	16  XCTest                              0x006949b7 -[XCTest runTest] + 45
   	17  XCTest                              0x00661a39 __27-[XCTestSuite performTest:]_block_invoke
+ 258
   	18  XCTest                              0x0066160b -[XCTestSuite _performProtectedSectionForTest:testSection:]
+ 32
   	19  XCTest                              0x0066181b -[XCTestSuite performTest:] + 213
   	20  XCTest                              0x006949b7 -[XCTest runTest] + 45
   	21  XCTest                              0x00661a39 __27-[XCTestSuite performTest:]_block_invoke
+ 258
   	22  XCTest                              0x0066160b -[XCTestSuite _performProtectedSectionForTest:testSection:]
+ 32
   	23  XCTest                              0x0066181b -[XCTestSuite performTest:] + 213
   	24  XCTest                              0x006949b7 -[XCTest runTest] + 45
   	25  XCTest                              0x006b0bdf __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke
+ 52
   	26  XCTest                              0x00671af7 -[XCTestObservationCenter _observeTestExecutionForBlock:]
+ 699
   	27  XCTest                              0x006b0a72 -[XCTTestRunSession runTestsAndReturnError:]
+ 295
   	28  XCTest                              0x0064be10 -[XCTestDriver runTestsAndReturnError:]
+ 255
   	29  XCTest                              0x006a83a1 _XCTestMain + 790
   	30  xctest                              0x0008bab2 xctest + 6834
   	31  libdyld.dylib                       0x020e6779 start + 1
   )
   Test Case '-[CameraTest testProcessImage]' failed (0.229 seconds).Test Case '-[CameraTest
testProcessImage]' started.
   2018-02-28 14:10:55.751 xctest[2330:8469] -[CDVCamera processImage:info:options:]: unrecognized
selector sent to instance 0x7976c770
   /Users/travis/build/apache/cordova-plugin-camera/tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m:481:
error: -[CameraTest testProcessImage] : failed: caught "NSInvalidArgumentException", "-[CDVCamera
processImage:info:options:]: unrecognized selector sent to instance 0x7976c770"
   (
   	0   CoreFoundation                      0x00c96ded __exceptionPreprocess + 189
   	1   libobjc.A.dylib                     0x00761d6f objc_exception_throw + 49
   	2   CoreFoundation                      0x00d085b8 -[NSObject(NSObject) doesNotRecognizeSelector:]
+ 136
   	3   CoreFoundation                      0x00c1ca8d ___forwarding___ + 941
   	4   CoreFoundation                      0x00c1c6be _CF_forwarding_prep_0 + 14
   	5   CDVCameraLibTests                   0x0edb4568 -[CameraTest testProcessImage] + 648
   	6   CoreFoundation                      0x00c1df4d __invoking___ + 29
   	7   CoreFoundation                      0x00c1de81 -[NSInvocation invoke] + 321
   	8   XCTest                              0x0066442b __24-[XCTestCase invokeTest]_block_invoke_2
+ 502
   	9   XCTest                              0x006a4b0a -[XCTestContext performInScope:] +
229
   	10  XCTest                              0x00664228 -[XCTestCase invokeTest] + 259
   	11  XCTest                              0x00664bc5 -[XCTestCase performTest:] + 621
   	12  XCTest                              0x006949b7 -[XCTest runTest] + 45
   	13  XCTest                              0x00661a39 __27-[XCTestSuite performTest:]_block_invoke
+ 258
   	14  XCTest                              0x0066160b -[XCTestSuite _performProtectedSectionForTest:testSection:]
+ 32
   	15  XCTest                              0x0066181b -[XCTestSuite performTest:] + 213
   	16  XCTest                              0x006949b7 -[XCTest runTest] + 45
   	17  XCTest                              0x00661a39 __27-[XCTestSuite performTest:]_block_invoke
+ 258
   	18  XCTest                              0x0066160b -[XCTestSuite _performProtectedSectionForTest:testSection:]
+ 32
   	19  XCTest                              0x0066181b -[XCTestSuite performTest:] + 213
   	20  XCTest                              0x006949b7 -[XCTest runTest] + 45
   	21  XCTest                              0x00661a39 __27-[XCTestSuite performTest:]_block_invoke
+ 258
   	22  XCTest                              0x0066160b -[XCTestSuite _performProtectedSectionForTest:testSection:]
+ 32
   	23  XCTest                              0x0066181b -[XCTestSuite performTest:] + 213
   	24  XCTest                              0x006949b7 -[XCTest runTest] + 45
   	25  XCTest                              0x006b0bdf __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke
+ 52
   	26  XCTest                              0x00671af7 -[XCTestObservationCenter _observeTestExecutionForBlock:]
+ 699
   	27  XCTest                              0x006b0a72 -[XCTTestRunSession runTestsAndReturnError:]
+ 295
   	28  XCTest                              0x0064be10 -[XCTestDriver runTestsAndReturnError:]
+ 255
   	29  XCTest                              0x006a83a1 _XCTestMain + 790
   	30  xctest                              0x0008bab2 xctest + 6834
   	31  libdyld.dylib                       0x020e6779 start + 1
   )
   Test Case '-[CameraTest testProcessImage]' failed (0.229 seconds).
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Importing corrupt images using the Camera plugin crashes the app
> ----------------------------------------------------------------
>
>                 Key: CB-13415
>                 URL: https://issues.apache.org/jira/browse/CB-13415
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-camera
>         Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>            Reporter: Shemrick Flannigan
>            Priority: Critical
>              Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the Cordova app which
uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error message relaying
the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app | https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner class to
prevent an app crash | https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes]

> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera plugin, such
as:
> #* Yelp mobile app
> #* Slack mobile app



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message