From issues-return-92417-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Wed Feb 7 21:24:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id EDCD118065B for ; Wed, 7 Feb 2018 21:24:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D19DA160C5B; Wed, 7 Feb 2018 20:24:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2397D160C3A for ; Wed, 7 Feb 2018 21:24:06 +0100 (CET) Received: (qmail 15448 invoked by uid 500); 7 Feb 2018 20:24:06 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 15436 invoked by uid 99); 7 Feb 2018 20:24:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Feb 2018 20:24:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BD142C1EA4 for ; Wed, 7 Feb 2018 20:24:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.011 X-Spam-Level: X-Spam-Status: No, score=-109.011 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id UCz5HvTN9lmt for ; Wed, 7 Feb 2018 20:24:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8520F5FB58 for ; Wed, 7 Feb 2018 20:24:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 98C60E0295 for ; Wed, 7 Feb 2018 20:24:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6BC602410C for ; Wed, 7 Feb 2018 20:24:00 +0000 (UTC) Date: Wed, 7 Feb 2018 20:24:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356015#comment-16356015 ] ASF GitHub Bot commented on CB-13829: ------------------------------------- janpio commented on issue #246: CB-13829 Fix tests that were broken since CB-13237 URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363898512 Thanks for the review @brodybits, very helpful. I did some smaller updates, and think I will "ignore" the other things for now. Do you think the "new"/rewritten tests are doing their job equivalent to what was there before? If you agree, I think I will just merge this in to see some progress here. If you have any ideas about https://issues.apache.org/jira/browse/CB-13834... I am pretty much out of ideas as I can't reproduce locally and don't know what is going on on AppVeyor :/ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Fix tests that were broken since CB-13237 > ----------------------------------------- > > Key: CB-13829 > URL: https://issues.apache.org/jira/browse/CB-13829 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows > Affects Versions: 6.0.0 > Reporter: Jan Piotrowski (Sujan) > Assignee: Jan Piotrowski (Sujan) > Priority: Major > > CB-13237 introduced a major breaking change (by default the projects built are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in the process (which wasn't noticed because the running of tests was broken even before by the switch from jasmine-node to jasmine and so CI didn'T report the test breakage). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org