From issues-return-92413-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Wed Feb 7 21:15:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id D872118065B for ; Wed, 7 Feb 2018 21:15:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C8356160C5B; Wed, 7 Feb 2018 20:15:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E6787160C5C for ; Wed, 7 Feb 2018 21:15:05 +0100 (CET) Received: (qmail 85814 invoked by uid 500); 7 Feb 2018 20:15:05 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 85803 invoked by uid 99); 7 Feb 2018 20:15:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Feb 2018 20:15:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 739691A0661 for ; Wed, 7 Feb 2018 20:15:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.011 X-Spam-Level: X-Spam-Status: No, score=-101.011 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 54FfTPczSCVp for ; Wed, 7 Feb 2018 20:15:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C062E5F230 for ; Wed, 7 Feb 2018 20:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C14FDE018A for ; Wed, 7 Feb 2018 20:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 27C1721E85 for ; Wed, 7 Feb 2018 20:15:00 +0000 (UTC) Date: Wed, 7 Feb 2018 20:15:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356002#comment-16356002 ] ASF GitHub Bot commented on CB-13829: ------------------------------------- janpio commented on a change in pull request #246: CB-13829 Fix tests that were broken since CB-13237 URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166741556 ########## File path: spec/e2e/endtoend.spec.js ########## @@ -54,34 +71,82 @@ describe('Cordova create and build', function () { expect(fs.existsSync(projectFolder)).toBe(true); }); - it('spec.2 should build project', function () { - shell.exec(buildScriptPath, {silent: true}); - var packages = shell.ls(appPackagesFolder); - expect(packages.filter(function (file) { return file.match(/.*Phone.*\.appx.*/); }).length).toBe(1); - expect(packages.filter(function (file) { return file.match(/.*Windows.*\.appx.*/); }).length).toBe(1); + // default + + it('spec.2 should build default (win10) project', function () { + shell.exec(buildScriptPath + '', {silent: silent}); + _expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx'); }); - it('spec.3 should build project for particular CPU', function () { - shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: true}); /* eslint no-useless-escape : 0 */ - var packages = shell.ls(appPackagesFolder); - expect(packages.filter(function (file) { return file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1); - expect(packages.filter(function (file) { return file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1); + // --appx + + it('spec.2a should build uap/win10 project', function () { + shell.exec(buildScriptPath + ' --appx=uap', {silent: silent}); + _expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx'); }); - it('spec.4 should build project for CPUs separated by whitespaces', function () { - shell.exec(buildScriptPath + ' --archs=\"x64 x86 arm anycpu\"', {silent: true}); /* eslint no-useless-escape : 0 */ - var packages = shell.ls(appPackagesFolder); - expect(packages.filter(function (file) { return file.match(/.*Phone.*x86.*\.appx.*/); }).length).toBe(1); - expect(packages.filter(function (file) { return file.match(/.*Phone.*x64.*\.appx.*/); }).length).toBe(1); - expect(packages.filter(function (file) { return file.match(/.*Phone.*arm.*\.appx.*/); }).length).toBe(1); - expect(packages.filter(function (file) { return file.match(/.*Phone.*AnyCPU.*\.appx.*/i); }).length).toBe(1); - expect(packages.filter(function (file) { return file.match(/.*Windows.*x64.*\.appx.*/); }).length).toBe(1); - expect(packages.filter(function (file) { return file.match(/.*Windows.*x86.*\.appx.*/); }).length).toBe(1); - expect(packages.filter(function (file) { return file.match(/.*Windows.*arm.*\.appx.*/); }).length).toBe(1); - expect(packages.filter(function (file) { return file.match(/.*Windows.*anycpu.*\.appx.*/i); }).length).toBe(1); + it('spec.2b should build 8.1 win project', function () { + shell.exec(buildScriptPath + ' --appx=8.1-win', {silent: silent}); + _expectExist(/.*Windows.*\.appxupload/); + }); + + it('spec.2c should build 8.1 phone project', function () { + shell.exec(buildScriptPath + ' --appx=8.1-phone', {silent: silent}); + _expectExist(/.*Phone.*\.appxupload/); }); - it('spec.5 should build project containing plugin with InProcessServer extension', function (done) { + it('spec.2c should build 8.1 win + phone project', function () { + shell.exec(buildScriptPath + ' --appx=8.1', {silent: silent}); + _expectExist(/.*Windows.*\.appxupload/); + _expectExist(/.*Phone.*\.appxupload/); + }); + + // --archs + + it('spec.3a should build project for particular CPU', function () { + shell.exec(buildScriptPath + ' --archs=\"x64\"', {silent: silent}); /* eslint no-useless-escape : 0 */ + _expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_x64_debug_Test', 'CordovaApp.Windows10_1.0.0.0_x64_debug.appx'); + }); + + it('spec.3b should build project (8.1) for particular CPU', function () { + shell.exec(buildScriptPath + ' --appx=8.1 --archs=\"x64\"', {silent: silent}); /* eslint no-useless-escape : 0 */ + _expectExist(/.*Phone.*x64.*\.appxupload/); + _expectExist(/.*Windows.*x64.*\.appxupload/); + }); + + it('spec.3c should build project (8.1-win) for particular CPU', function () { + shell.exec(buildScriptPath + ' --appx=8.1-win --archs=\"x64\"', {silent: silent}); /* eslint no-useless-escape : 0 */ + _expectExist(/.*Windows.*x64.*\.appxupload/); + }); + + it('spec.3d should build project (8.1-phone) for particular CPU', function () { + shell.exec(buildScriptPath + ' --appx=8.1-phone --archs=\"x64\"', {silent: silent}); /* eslint no-useless-escape : 0 */ + _expectExist(/.*Phone.*x64.*\.appxupload/); + }); + + it('spec.4a should build project for CPUs separated by whitespaces', function () { + shell.exec(buildScriptPath + ' --archs=\"x64 x86 arm anycpu\"', {silent: silent}); /* eslint no-useless-escape : 0 */ + _expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_x64_debug_Test', 'CordovaApp.Windows10_1.0.0.0_x64_debug.appx'); Review comment: out of scope, but also good candidate for follow up PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Fix tests that were broken since CB-13237 > ----------------------------------------- > > Key: CB-13829 > URL: https://issues.apache.org/jira/browse/CB-13829 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows > Affects Versions: 6.0.0 > Reporter: Jan Piotrowski (Sujan) > Assignee: Jan Piotrowski (Sujan) > Priority: Major > > CB-13237 introduced a major breaking change (by default the projects built are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in the process (which wasn't noticed because the running of tests was broken even before by the switch from jasmine-node to jasmine and so CI didn'T report the test breakage). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org