From issues-return-92387-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Wed Feb 7 15:12:07 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id BC9D5180676 for ; Wed, 7 Feb 2018 15:12:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id ACA58160C3C; Wed, 7 Feb 2018 14:12:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0752E160C5B for ; Wed, 7 Feb 2018 15:12:06 +0100 (CET) Received: (qmail 4492 invoked by uid 500); 7 Feb 2018 14:12:06 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 4476 invoked by uid 99); 7 Feb 2018 14:12:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Feb 2018 14:12:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A06BEC0385 for ; Wed, 7 Feb 2018 14:12:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.011 X-Spam-Level: X-Spam-Status: No, score=-109.011 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id G0IVRJPdUpL8 for ; Wed, 7 Feb 2018 14:12:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5E57D5F5B3 for ; Wed, 7 Feb 2018 14:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A4FBEE0237 for ; Wed, 7 Feb 2018 14:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 55513240F6 for ; Wed, 7 Feb 2018 14:12:00 +0000 (UTC) Date: Wed, 7 Feb 2018 14:12:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355484#comment-16355484 ] ASF GitHub Bot commented on CB-13829: ------------------------------------- janpio commented on issue #246: CB-13829 Fix tests that were broken since CB-13237 URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363780207 https://github.com/apache/cordova-windows/commit/dd91933d7030f6f0bb207a676968c4fdad9e3691 has nothing to do with this, it was just a commit of the release process that is documented here: https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#update-and-pin-dependencies It had to be reverted as the release process was canceled as I discovered the failing tests and breaking changes (which requires a 6.0 release instead of a 5.1 I was working on). The culprit for the failing tests is in https://issues.apache.org/jira/browse/CB-13237 / https://github.com/apache/cordova-windows/commit/c1dfc77ddf866b4872330eb2b8874ede05daddcd but wasn't noticed as earlier `jasmine-node` was replaced by `jasmine` which doesn't have the same command line params, which caused the tests to fail silently and not to be run at all via https://github.com/apache/cordova-windows/commit/1c6d245fbb10ab71c77eed6a73989827042422f5 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Fix tests that were broken since CB-13237 > ----------------------------------------- > > Key: CB-13829 > URL: https://issues.apache.org/jira/browse/CB-13829 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows > Affects Versions: 6.0.0 > Reporter: Jan Piotrowski (Sujan) > Assignee: Jan Piotrowski (Sujan) > Priority: Major > > CB-13237 introduced a major breaking change (by default the projects built are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in the process (which wasn't noticed because the running of tests was broken even before by the switch from jasmine-node to jasmine and so CI didn'T report the test breakage). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org