From issues-return-92896-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Thu Feb 22 22:05:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0775A18064E for ; Thu, 22 Feb 2018 22:05:04 +0100 (CET) Received: (qmail 11407 invoked by uid 500); 22 Feb 2018 21:05:04 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 11396 invoked by uid 99); 22 Feb 2018 21:05:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Feb 2018 21:05:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 77672C0145 for ; Thu, 22 Feb 2018 21:05:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Ez9Pf4K_BboN for ; Thu, 22 Feb 2018 21:05:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4D2A95FB5E for ; Thu, 22 Feb 2018 21:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6C356E01AE for ; Thu, 22 Feb 2018 21:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 202A727127 for ; Thu, 22 Feb 2018 21:05:00 +0000 (UTC) Date: Thu, 22 Feb 2018 21:05:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-13828) Improve cordova-coho/docs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373445#comment-16373445 ] ASF GitHub Bot commented on CB-13828: ------------------------------------- janpio commented on a change in pull request #170: CB-13828: Improve cordova-coho/docs URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170092319 ########## File path: docs/platforms-release-process.md ########## @@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have Apache-compatible licenses. coho check-license -r android ## Prepare Release -Increase the version within package.json using SemVer, and remove the `-dev` suffix. + +### Remove the `-dev` suffix from version + +This command removes `-dev` from the `version` entry in `package.json`: for l in cordova-android; do ( cd $l; v="$(grep '"version"' package.json | cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json; fi) ; done -In `cordova-android`, also remember to bump the version in `framework/build.gradle`. +Note: This command [doesn't actually work](https://issues.apache.org/jira/browse/CB-13809). You can also replace `-dev` manually of course. -If the changes merit it, manually bump the major / minor/ patch version in `package.json`. View the changes via: +Note: In `cordova-android`, also remember to handle the version in `framework/build.gradle`. + +### Increase version + +If the changes merit it, **manually** bump the major / minor/ patch version in `package.json`. + +To decide if this release merits it, view the changes via: ( cd cordova-android && git log --pretty=format:'* %s' --topo-order --no-merges $(git describe --tags $(git rev-list --tags --max-count=1))..master ) +Note: This command [doesn't actually work](https://issues.apache.org/jira/browse/CB-13901). You can also check out the changes manually (or via the next step). Review comment: Just noticed that I only ran this on Windows shell, not WSL/bash so this one might actually be just a different in the params of `git` on Windows. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Improve cordova-coho/docs > ------------------------- > > Key: CB-13828 > URL: https://issues.apache.org/jira/browse/CB-13828 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-coho > Reporter: Jan Piotrowski (Sujan) > Priority: Major > > /docs in the `cordova-coho` repo is effectively the contributor documentation of Cordova. It could use some improvements right now. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org