From issues-return-92652-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Wed Feb 14 20:46:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C98D1180621 for ; Wed, 14 Feb 2018 20:46:04 +0100 (CET) Received: (qmail 73267 invoked by uid 500); 14 Feb 2018 19:46:03 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 73256 invoked by uid 99); 14 Feb 2018 19:46:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 19:46:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7761BC0186 for ; Wed, 14 Feb 2018 19:46:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id MEiorhdF4nqA for ; Wed, 14 Feb 2018 19:46:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 767255F3F0 for ; Wed, 14 Feb 2018 19:46:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9E304E0296 for ; Wed, 14 Feb 2018 19:46:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 422842411A for ; Wed, 14 Feb 2018 19:46:00 +0000 (UTC) Date: Wed, 14 Feb 2018 19:46:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-13522) Remove ios usage description from cordova-plugin-contacts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364669#comment-16364669 ] ASF GitHub Bot commented on CB-13522: ------------------------------------- brandon-applied commented on issue #158: CB-13522 (iOS): Remove usage description URL: https://github.com/apache/cordova-plugin-contacts/pull/158#issuecomment-365723115 @jcesarmobile quick question - why was this change necessary? I've looked at the Jira issue and no mention of why this change was required? Failing to include the usage description in the manner described in the updated readme just causes the plugin to crash the app as soon as I attempt to read the contacts. For anyone upgrading, this "fix" just breaks the app. Seems like this fix should at least have updated the plugin to call the error callback if no permission text is available rather than crash. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Remove ios usage description from cordova-plugin-contacts > --------------------------------------------------------- > > Key: CB-13522 > URL: https://issues.apache.org/jira/browse/CB-13522 > Project: Apache Cordova > Issue Type: Sub-task > Reporter: jcesarmobile > Assignee: jcesarmobile > Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org