cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Brody (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13859) Mismatch between package.json and bundled node_modules dependencies on cordova-windows
Date Fri, 09 Feb 2018 17:16:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358719#comment-16358719
] 

Chris Brody commented on CB-13859:
----------------------------------

Additional comments:
 * There are some other artifacts committed in node_modules that are not tracked in package.json
(artifact of npm install process). I would prefer to see all such bundled artifacts tracked
with exact (absolute) version numbers in package.json.
 * It would be ideal not to keep node_modules in the repository but instead use {{npm prepare}}
/ {{npm prepublish}} scripts to fetch as needed (needed node_modules would still be part of
the npm package).
 * I think all items will apply for the other platforms.

I would be happy to take a look at all of these items over the next 1-2 weeks.

> Mismatch between package.json and bundled node_modules dependencies on cordova-windows
> --------------------------------------------------------------------------------------
>
>                 Key: CB-13859
>                 URL: https://issues.apache.org/jira/browse/CB-13859
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: Chris Brody
>            Assignee: Jesse MacFadyen
>            Priority: Major
>
> If I checkout cordova-windows and do npm install on the master branch, it shows a mismatch
between dependencies (bundledDependencies) in package.json and bundled dependencies committed
in node_modules. This can lead to some confusion when testing locally. Lets keep these consistent,
please.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message