cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13852) cordova-plugin-media getPosition audio failed
Date Mon, 05 Feb 2018 20:47:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352916#comment-16352916
] 

ASF GitHub Bot commented on CB-13852:
-------------------------------------

jsdussanc opened a new pull request #165: CB-13852: (iOS) Fix bug prevent error on getPosition
URL: https://github.com/apache/cordova-plugin-media/pull/165
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   When I try to get the position of an audio that had an error while loading, the crash appose
exponentially because it can not cast the time = none
   
   ### Platforms affected
   iOS xx
   
   ### What does this PR do?
   
   if the time is none, return the value of position at default = -1
   
   ### What testing has been done on this change?
   It does not affect much, I tested it in my personal project
   
   ### Checklist
   - [ x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [ x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change. (I don`t know)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> cordova-plugin-media getPosition audio failed
> ---------------------------------------------
>
>                 Key: CB-13852
>                 URL: https://issues.apache.org/jira/browse/CB-13852
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-media
>    Affects Versions: cordova-ios 4.5.0
>         Environment: iOS all versions
>            Reporter: Juan Sebastian Dussan Cubides
>            Priority: Minor
>
> (iOS)
> When I try to get the position of an audio that had an error while loading, the crash
appose exponentially because it can not cast the time = none



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message