cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13849) getDirectory('') returns root path
Date Tue, 06 Feb 2018 01:06:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353183#comment-16353183
] 

ASF GitHub Bot commented on CB-13849:
-------------------------------------

Beutlin opened a new pull request #230: CB-13849: (android) getDirectory("") returns current
path instead of / path
URL: https://github.com/apache/cordova-plugin-file/pull/230
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   - Android
   
   
   ### What does this PR do?
   Currently the comman getDirectory('') with an empty parameter returns always the root path.
It does not matter on which path this command is executed. This is an unexpected behaviour
and might cause security issues.
   With this patch the path of the current directory is returned, like in other implementations
(i.e. browser).
   
   ### What testing has been done on this change?
   It has been tested on an emulator. Furthermore the sourcecode has been evaluated and there
is no negative issues with it. 
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> getDirectory('') returns root path
> ----------------------------------
>
>                 Key: CB-13849
>                 URL: https://issues.apache.org/jira/browse/CB-13849
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-file
>    Affects Versions: cordova-android-7.0.0
>         Environment: Android
>            Reporter: Tobias Haupenthal
>            Priority: Major
>
> At the moment the command \{someDir}.getDirectory("") with a blank argument returns the
root-path.
> If someone works already on a subdirectory that behaviour might be a security flaw.
> Better would be to return the current directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message