cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237
Date Wed, 07 Feb 2018 20:42:01 GMT


ASF GitHub Bot commented on CB-13829:

brodybits commented on issue #246: CB-13829 Fix tests that were broken since CB-13237
   > In my opinion these changes actually are only to fix the previously existing tests
   It is clear to me that a major goal is to pass most of the existing test cases. It is not
clear to me whether or not the following items are other goals of this change:
   - fix actual script behavior
   - fix test cases that were incorrect
   > I didn't really extend the test coverage, did I?
   It looks like the following test cases were added: 2b, 2c, 2d, 2e, 3b, 3c, 3d, 4b, 5b,
   It appears that the test coverage would be expanded to cover Windows 8.1, Windows Phone
8.1, Windows 10 and all possible CPU targets more completely.
   > I did some smaller changes, and think I will "ignore" the other things for now.
   Fine for me, they are all minor anyway.
   > Do you think the "new"/rewritten tests are doing their job equivalent to what was
there before?
   Yes, with more complete coverage of Windows 8.1/Windows Phone 8.1/Windows 10 build and
all CPU targets.
   > If you agree, I think I will just merge this in to see some progress here.
   Yes, please.
   In general I think this is a major step in the right direction. I would be happy to take
a look at CB-13834, cannot promise anything though. I am still hoping we can have a release
within the next few days to solve the Windows 8.1 crash problem.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Fix tests that were broken since CB-13237
> -----------------------------------------
>                 Key: CB-13829
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>    Affects Versions: 6.0.0
>            Reporter: Jan Piotrowski (Sujan)
>            Assignee: Jan Piotrowski (Sujan)
>            Priority: Major
> CB-13237 introduced a major breaking change (by default the projects built are not Windows10/UWP
and not 8.1 any more) and also broke the e2e-tests in the process (which wasn't noticed because
the running of tests was broken even before by the switch from jasmine-node to jasmine and
so CI didn'T report the test breakage).

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message