cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13829) Fix tests that were broken since CB-13237
Date Wed, 07 Feb 2018 17:10:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355731#comment-16355731
] 

ASF GitHub Bot commented on CB-13829:
-------------------------------------

brodybits commented on a change in pull request #246: CB-13829 Fix tests that were broken
since CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#discussion_r166687229
 
 

 ##########
 File path: spec/e2e/endtoend.spec.js
 ##########
 @@ -34,15 +34,32 @@ describe('Cordova create and build', function () {
     var buildDirectory = path.join(__dirname, '../..');
     var appPackagesFolder = path.join(buildDirectory, projectFolder, 'AppPackages');
     var buildScriptPath = '"' + path.join(buildDirectory, projectFolder, 'cordova', 'build')
+ '"';
+    var silent = false;
+
+    function verifySubDirContainsFile (subDirName, fileName, count) {
+        count = typeof count !== 'undefined' ? count : 1;
 
-    function verifySubDirContainsFile (subDirName, fileName) {
         var subDir = path.join(appPackagesFolder, subDirName);
         var packages = shell.ls(subDir);
-        expect(packages.filter(function (file) { return file.match(fileName); }).length).toBe(1);
+        expect(packages.filter(function (file) { return file.match(fileName); }).length).toBe(count);
+    }
+
+    function _expectExist (fileNamePattern, count) {
+        count = typeof count !== 'undefined' ? count : 1;
 
 Review comment:
   ditto

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix tests that were broken since CB-13237
> -----------------------------------------
>
>                 Key: CB-13829
>                 URL: https://issues.apache.org/jira/browse/CB-13829
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>    Affects Versions: 6.0.0
>            Reporter: Jan Piotrowski (Sujan)
>            Assignee: Jan Piotrowski (Sujan)
>            Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built are not Windows10/UWP
and not 8.1 any more) and also broke the e2e-tests in the process (which wasn't noticed because
the running of tests was broken even before by the switch from jasmine-node to jasmine and
so CI didn'T report the test breakage).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message