cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13522) Remove ios usage description from cordova-plugin-contacts
Date Wed, 14 Feb 2018 19:46:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364669#comment-16364669
] 

ASF GitHub Bot commented on CB-13522:
-------------------------------------

brandon-applied commented on issue #158: CB-13522 (iOS): Remove usage description
URL: https://github.com/apache/cordova-plugin-contacts/pull/158#issuecomment-365723115
 
 
   @jcesarmobile quick question - why was this change necessary? I've looked at the Jira issue
and no mention of why this change was required? 
   
   Failing to include the usage description in the manner described in the updated readme
just causes the plugin to crash the app as soon as I attempt to read the contacts. For anyone
upgrading, this "fix" just breaks the app. Seems like this fix should at least have updated
the plugin to call the error callback if no permission text is available rather than crash.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove ios usage description from cordova-plugin-contacts
> ---------------------------------------------------------
>
>                 Key: CB-13522
>                 URL: https://issues.apache.org/jira/browse/CB-13522
>             Project: Apache Cordova
>          Issue Type: Sub-task
>            Reporter: jcesarmobile
>            Assignee: jcesarmobile
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message