cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13449) Added support for 1024x1024 app icon
Date Thu, 01 Feb 2018 05:28:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348030#comment-16348030
] 

ASF GitHub Bot commented on CB-13449:
-------------------------------------

tripodsan closed pull request #47: CB-13449: (osx) assign 1024x1024 app icon
URL: https://github.com/apache/cordova-osx/pull/47
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/project/__PROJECT_NAME__/Images.xcassets/AppIcon.appiconset/Contents.json
b/bin/templates/project/__PROJECT_NAME__/Images.xcassets/AppIcon.appiconset/Contents.json
index 52c438f1..0fabd3dc 100644
--- a/bin/templates/project/__PROJECT_NAME__/Images.xcassets/AppIcon.appiconset/Contents.json
+++ b/bin/templates/project/__PROJECT_NAME__/Images.xcassets/AppIcon.appiconset/Contents.json
@@ -57,6 +57,7 @@
         {
             "idiom": "mac",
             "size": "512x512",
+            "filename": "icon-1024x1024.png",
             "scale": "2x"
         }
     ],


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Added support for 1024x1024 app icon
> ------------------------------------
>
>                 Key: CB-13449
>                 URL: https://issues.apache.org/jira/browse/CB-13449
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-osx
>            Reporter: Tobias Bocanegra
>            Assignee: Tobias Bocanegra
>            Priority: Major
>             Fix For: 4.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message