cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13193) Setting orientation to landscape might turn UI upside down if already in landscape
Date Mon, 12 Feb 2018 02:16:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360217#comment-16360217
] 

ASF GitHub Bot commented on CB-13193:
-------------------------------------

fortunes-technology commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape Orientation
turn up-sidedown
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/25#issuecomment-364814425
 
 
   The Merge conflict fixed. 
   This PR fixes, the landscape right and left issue.
   Also if you want to lock orientation to landscape (do not care when it is right or left)
and it's already in landscape mode (whether it is right or left), we shouldn't be changing
orientation.
   Right now, if we change orientation to landscape, it just change it to landscape left.
   So this is fixed with this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Setting orientation to landscape might turn UI upside down if already in landscape
> ----------------------------------------------------------------------------------
>
>                 Key: CB-13193
>                 URL: https://issues.apache.org/jira/browse/CB-13193
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-screen-orientation
>            Reporter: Jonathan Herdt
>            Assignee: Vishal Mishra
>            Priority: Major
>
> Steps to reproduce:
> # Set up an app to lock its orientation to 'landscape' at startup via `screen.orientation.lock('landscape')`
> # Set device to landscape-left (home button on left side)
> # Start app
> # Observe UI turning upside down
> Desired behavior: Rotation is locked but UI does not turn upside down



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message