cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13175) 8.1-win crashes on startup
Date Wed, 07 Feb 2018 21:19:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356093#comment-16356093
] 

ASF GitHub Bot commented on CB-13175:
-------------------------------------

brodybits commented on issue #239: CB-13175: fixing windows8.1 crash on startup
URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-363913932
 
 
   This issue is fixed in 2e597ef1084088341b102d6e4c6a8ea465f7dce1 which will be in 5.1. But
5.1 is now held up due to some test failures as discussed in PR #246. Is it possible that
we can cherry-pick 2e597ef1084088341b102d6e4c6a8ea465f7dce1 on the `5.0.x` branch and release
it there?
   
   I would like to see this resolved ASAP for Windows 8.1. I would be happy to raise a new
PR to cherry-pick this on the `5.0.x` branch if it would help.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> 8.1-win crashes on startup
> --------------------------
>
>                 Key: CB-13175
>                 URL: https://issues.apache.org/jira/browse/CB-13175
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>    Affects Versions: Master
>            Reporter: Max Kapaln
>            Assignee: Jesse MacFadyen
>            Priority: Major
>
> This ticket is a follow up to CB-12784
> The PR submitted with CB-12784 only half fixed the win8 crashing issue. The functions
colorizeTitleBar() and revertTitleBarColor() exist in template/www/cordova.js as well and
my PR takes the fix the user applied in CB-12784 and adds into cordova.js as well.
> alsorokin original fix (already merged into master):
> https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message