cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13145) Create playservices version preference in config.xml
Date Thu, 01 Feb 2018 14:16:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348632#comment-16348632
] 

ASF GitHub Bot commented on CB-13145:
-------------------------------------

macdonst commented on issue #590: CB-13145: Create playservices version preference in config.xml

URL: https://github.com/apache/cordova-lib/pull/590#issuecomment-362277878
 
 
   @adriano-di-giovanni the way it works is you can set a preference in config.xml or plugin.xml.
The config.xml one over-rides the one in plugin.xml if they have the same name. 
   
   Check out the push plugin: 
   
   https://github.com/phonegap/phonegap-plugin-push/blob/master/plugin.xml#L47
   
   I set a default FCM version but folks can over-ride it. Then the user can make all these
versions match in config.xml.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Create playservices version preference in config.xml
> ----------------------------------------------------
>
>                 Key: CB-13145
>                 URL: https://issues.apache.org/jira/browse/CB-13145
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>            Reporter: Steve Gill
>            Priority: Major
>              Labels: backlog, tools-next
>             Fix For: cordova@7.2.0
>
>
> We are seeing an issue in the community of two plugins using different versions of google
play services. This causes gradle to error out. We are running into this with the phonegap-push-plugin.
> Potential solution:
> We could create an Android only preference called PlayServicesVersion in config.xml which
would control the version of Play Services used for the entire project.
> In config.xml:
> {code}
> <preference name="PlayServicesVersion" value="11.0.1"/>
> {code}
> Then if the push plugin wanted to include the FCM libraries in it's plugin.xml it would
do:
> <framework src="com.google.firebase:firebase-messaging:$PlayServicesVersion"/>
> and the cordova-plugin-google-analytics wanted to include Play Services in it's plugin.xml
it would do:
> {code}
> <framework src="com.google.android.gms:play-services-analytics:$PlayServicesVersion"
/>
> {code}
> they would both use the same version of Play Services. This gets around the problem of
plugins using + in the framework tag and having two plugins pin different versions of Play
Services.
> The + wildcard fails to compile with the following error:
> {code}
> > Failed to apply plugin [id 'com.google.gms.google-services']
>    > For input string: "+"
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message