cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it
Date Mon, 26 Feb 2018 05:40:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376406#comment-16376406
] 

ASF GitHub Bot commented on CB-12582:
-------------------------------------

shazron closed pull request #354: CB-12582: exec purgeProjectFileCache when pod install
URL: https://github.com/apache/cordova-ios/pull/354
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/scripts/cordova/Api.js b/bin/templates/scripts/cordova/Api.js
index dd50d11f8..04da4a1bd 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) {
             if (podfileFile.isDirty()) {
                 podfileFile.write();
                 events.emit('verbose', 'Running `pod install` (to install plugins)');
+                projectFile.purgeProjectFileCache(self.locations.root);
 
                 return podfileFile.install(check_reqs.check_cocoapods);
             } else {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Plugin's Cocoapods don't persist if another plugin is added after it
> --------------------------------------------------------------------
>
>                 Key: CB-12582
>                 URL: https://issues.apache.org/jira/browse/CB-12582
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-ios
>    Affects Versions: cordova-ios@4.3.1, 6.5.0
>            Reporter: Kyle Kirbatski
>            Assignee: Shazron Abdullah
>            Priority: Major
>              Labels: backlog
>             Fix For: cordova-ios@4.5.1
>
>         Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because the frameworks
added by Cocoapods (referenced from the plugin's xml) were not being found for linking. After
some investigation it appears that if a plugin is added after a plugin that uses cocoapods
then the changes made by cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message