cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
Date Fri, 23 Feb 2018 15:38:00 GMT


ASF GitHub Bot commented on CB-12242:

janpio commented on a change in pull request #14: CB-12242 : Use yarn instead of npm

 File path: index.js
 @@ -39,13 +39,14 @@ var hostedGitInfo = require('hosted-git-info');
 module.exports = function (target, dest, opts) {
-    var fetchArgs = ? ['link'] : ['install'];
     opts = opts || {};
+    var manager = opts.manager || 'npm';
+    var fetchArgs = ? ['link'] : manager === 'yarn' ? ['add'] : ['install'];
     var tree1;
     var nodeModulesDir = dest;
     // check if npm is installed
 Review comment:
   this line says that it checks if "npm is installed". this is not true any more, also pretty
self explaining now per function name, so comment can just be removed.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Use yarn js instead of npm when adding plugins
> ----------------------------------------------
>                 Key: CB-12242
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-cli, cordova-lib
>            Reporter: Jacques de Villiers
>            Priority: Major
> Currently it can take quite long to add certain plugins to my project (using cordova
plugin add), especially if I need to re-add the plugins. My suggestion is to update the cordova
cli to start using yarn js instead of npm directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and much better
at caching packages locally.
> I would imagine this change would be relatively straightforward, and would be a massive
win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally sure how to
proceed on this.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message