cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
Date Fri, 23 Feb 2018 14:00:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374373#comment-16374373
] 

ASF GitHub Bot commented on CB-12242:
-------------------------------------

janpio commented on a change in pull request #14: CB-12242 : Use yarn instead of npm
URL: https://github.com/apache/cordova-fetch/pull/14#discussion_r170257217
 
 

 ##########
 File path: index.js
 ##########
 @@ -39,13 +39,14 @@ var hostedGitInfo = require('hosted-git-info');
  *
  */
 module.exports = function (target, dest, opts) {
-    var fetchArgs = opts.link ? ['link'] : ['install'];
     opts = opts || {};
+    var manager = opts.manager || 'npm';
+    var fetchArgs = opts.link ? ['link'] : manager === 'yarn' ? ['add'] : ['install'];
     var tree1;
     var nodeModulesDir = dest;
 
     // check if npm is installed
 
 Review comment:
   comment is out of date

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use yarn js instead of npm when adding plugins
> ----------------------------------------------
>
>                 Key: CB-12242
>                 URL: https://issues.apache.org/jira/browse/CB-12242
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-cli, cordova-lib
>            Reporter: Jacques de Villiers
>            Priority: Major
>
> Currently it can take quite long to add certain plugins to my project (using cordova
plugin add), especially if I need to re-add the plugins. My suggestion is to update the cordova
cli to start using yarn js instead of npm directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and much better
at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be a massive
win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally sure how to
proceed on this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message