From issues-return-91839-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Thu Jan 18 19:54:09 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id AA901180654 for ; Thu, 18 Jan 2018 19:54:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9A97B160C2B; Thu, 18 Jan 2018 18:54:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E3511160C26 for ; Thu, 18 Jan 2018 19:54:08 +0100 (CET) Received: (qmail 1175 invoked by uid 500); 18 Jan 2018 18:54:08 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 1164 invoked by uid 99); 18 Jan 2018 18:54:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jan 2018 18:54:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 908461A753D for ; Thu, 18 Jan 2018 18:54:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.711 X-Spam-Level: X-Spam-Status: No, score=-100.711 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id UGGpvND8jSLe for ; Thu, 18 Jan 2018 18:54:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 582725F47F for ; Thu, 18 Jan 2018 18:54:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4C2FEE0F6E for ; Thu, 18 Jan 2018 18:54:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AA6A52130A for ; Thu, 18 Jan 2018 18:54:00 +0000 (UTC) Date: Thu, 18 Jan 2018 18:54:00 +0000 (UTC) From: "Joe Bowser (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-13647) Incomplete plugin restoration MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Auto-Submitted: auto-generated [ https://issues.apache.org/jira/browse/CB-13647?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D163309= 76#comment-16330976 ]=20 Joe Bowser commented on CB-13647: --------------------------------- [~goffioul]=C2=A0Unfortunately I don't have a timeframe as to when the plug= in paths will be changed.=C2=A0 We've tested the core plugins with mobilesp= ec, and all of them currently install, so that's not a pressing issue curre= ntly. > Incomplete plugin restoration > ----------------------------- > > Key: CB-13647 > URL: https://issues.apache.org/jira/browse/CB-13647 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android > Affects Versions: 7.0.0 > Reporter: Michael Goffioul > Assignee: Joe Bowser > Priority: Major > Labels: android-next > > I'm having a problem with plugin restoration since cordova-android 7.0.0,= when plugins use a mix of config-file and edit-config on the same file (e.= g. AndroidManifest.xml) and only edit-config uses the real path to the file= . I've tried both cordova-cli 6.5.0 and 7.1.0 with the same result. > 1) Create a new corodva project and enter top-level direcotyr > 2) Create subfolder to contain a local plugin: mkdir -p localplugins/test= plugin1 > 3) Create the following files to define the local plugin: > - plugin.xml (adds an attribute to and a category to ) > {code} > > > Test Plugin 1 > > > > > > > > > > {code} > - package.json > {code} > { > "name": "com.example.testplugin1", > "version": "1.0.0" > } > {code} > 4) Add android platform: cordova platform add android@7.0.0 --save > 5) Add local plugin: cordova plugin add localplugins/testplugin1 --save > At this point, if you check platforms/android/app/src/main/AndroidManifes= t.xml, it'll contain the 2 changes defined in the plugin. > Now attempt to use platform/plugin restoration with thw following: > {code} > cordova platform rm android > cordova prepare android > {code} > If you check again AndroidManifest.xml, it will only contain one of the c= hanges defined in the plugin (the attribute to ). The other ch= ange is missing. > If you use the real path to AndroidManifest.xml for the definition of , then the problem does not occur. BUT, the problem can also occu= r when changes to AndroidManifest.xml are coming from multiple plugins, inc= luding the standard cordova plugin, most of which do not use the real path = to AndroidManifest.xml yet. > The problem can affect other files too. For instance I experienced incomp= lete restoration of plugins trying to register themselves in res/xml/config= .xml. Only one plugin, out of 7, was using the real path app/src/main/res/x= ml/config.xml and I ended up with only one plugin defined in res/xml/config= .xml, causing the application to fail to start. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org