cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Brody (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CB-13796) Uncaught exception in Windows 8.1 build
Date Thu, 18 Jan 2018 19:31:04 GMT
Chris Brody created CB-13796:
--------------------------------

             Summary: Uncaught exception in Windows 8.1 build
                 Key: CB-13796
                 URL: https://issues.apache.org/jira/browse/CB-13796
             Project: Apache Cordova
          Issue Type: Bug
          Components: cordova-windows
    Affects Versions: 5.0.0, 5.1.0
         Environment: Cordova CLI 8.0.0 on Windows 10 Professional system with Visual Studio
2015 Update 3 (Community Edition)
            Reporter: Chris Brody
            Assignee: Jesse MacFadyen


If I would try the following steps:
 # create a new project using Cordova CLI 8.0.0
 # do {{cordova platform add windows}} (uses cordova-windows@5.0.0)
 # open the generated project with Visual Studio 2015
 # attempt to run Windows 8.1 build on my system

it would break with an exception at line 2083, column 9 in cordova.js.

I would encounter a similar issue if I would replace step 2 above with the following command:
 * {{cordova platform add [https://github.com/apache/cordova-windows]}}

(shows the following relevant output: {{Windows project created with cordova-windows@5.1.0-dev}})

*POSSIBLE WORKAROUND HACK SOLUTION:*

If I would MANUALLY APPLY the change in [apache/cordova-windows@2798167|https://github.com/apache/cordova-windows/commit/279816743f995510a1070a0bf77a3180f11e468a]
for CB-12784 (Fixed a crash on Windows 10 Creators Update):
 * replace {{appView.titleBar}} with {{isWin10UWP}} in {{colorizeTitleBar}} and {{revertTitleBarColor}}
functions in cordova.js (right around the code that fails)

then it would run OK.

This WORKAROUND HACK works for me regardless of whether I used {{cordova platform add windows}}
(using {{cordova-windows@5.0.0}}) or {{cordova platform add [https://github.com/apache/cordova-windows]}}
(using {{Windows project created with cordova-windows@5.1.0-dev}}).

*POSSIBLE EXPLANATION:*

 My theory is that for some reasons fixes made to splashscreen.js in [apache/cordova-windows@2798167|https://github.com/apache/cordova-windows/commit/279816743f995510a1070a0bf77a3180f11e468a]
(see [apache/cordova-windows#232 (CB-12784 Fixed a crash on Windows 10 Creators Update)|https://github.com/apache/cordova-windows/pull/232])
are not synchronized into cordova.js, as stated in [apache/cordova-windows@2798167#commitcomment-26631344|https://github.com/apache/cordova-windows/commit/279816743f995510a1070a0bf77a3180f11e468a#commitcomment-26631344].

ADDITIONAL NOTE: CB-12784 seems to be intended to fix a problem that was introduced by the
change in CB-12238 ([Windows] Colorize titlebar to match splash bg color).

I originally noted this issue in [brodybits/cordova-notes#3|https://github.com/brodybits/cordova-notes/issues/3],
along with the exception messages from Visual Studio 2015.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message