cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13791) Add Android support for a footer close button.
Date Thu, 25 Jan 2018 19:54:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339762#comment-16339762
] 

ASF subversion and git services commented on CB-13791:
------------------------------------------------------

Commit 98ee2e148cd98a6e0b627b9b92f2e03efd9e00c5 in cordova-plugin-inappbrowser's branch refs/heads/2.0.x
from [~bowserj]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=98ee2e1 ]

Merge pull request #258 from dpa99c/CB-13791

CB-13791: (android) Add Android support for a footer close button

> Add Android support for a footer close button.
> ----------------------------------------------
>
>                 Key: CB-13791
>                 URL: https://issues.apache.org/jira/browse/CB-13791
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-inappbrowser
>         Environment: Android
>            Reporter: Dave Alden
>            Priority: Minor
>              Labels: features, newbie
>
> Extending the work done in [PR #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under CB-13409,
this adds support to Android for a footer close button similar to the "Done" button on iOS.
> The following options are added for Android:
>  * *footer* - set to "yes" to show a close button in the footer similar to the iOS "Done"
button.
>  The close button will appear the same as for the header hence use _closebuttoncaption_
and _closebuttoncolor_ to set its properties.
>  * *footercolor* - set to a valid hex color string, for example #00ff00 or #CC00ff00
(#aarrggbb) , and it will change the footer color from default. Only has effect if user has
_footer_ set to "yes".
> Here are some example screenshots with the relevant options:
> _location=yes,footer=yes_
>  !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!
> _location=no,footer=yes_
>  !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!
> _location=yes,footer=yes,closebuttoncaption=Done_
>  !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!
> _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#0000ff_
>  !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!
> _location=no,footer=yes,footercolor=#0000ff,closebuttoncaption=Done_
>  !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!
> _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#0000ff_
>  !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!
> _location=no,footer=yes,footercolor=#CC000000,closebuttoncaption=Done,closebuttoncolor=#00FFFF_
>  !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message