cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
Date Sun, 28 Jan 2018 15:53:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342616#comment-16342616
] 

ASF GitHub Bot commented on CB-13415:
-------------------------------------

ShemrickFlannigan commented on issue #309: CB-13415 (android) Importing corrupt images using
the Camera plugin c…
URL: https://github.com/apache/cordova-plugin-camera/pull/309#issuecomment-361072781
 
 
   @jcesarmobile @infil00p I agree that the OutOfMemoryError is a catch all that is not specific
to corrupt images.
   But in our testing, the OutOfMemoryError is the only exception which we've found that successfully
captures the corrupt images.
   In our testing, there is no correlation with file size. The corrupts sample image which
has been provided is < 5MB. The Cordova Camera app can handle non-corrupt images which
are 40MB.
   
   Here are the sample images:
   
   Corrupt 5MB image:
   https://www.dropbox.com/s/s7jh3eay3y23oy1/5mb_13500x13500.D2%5B1%5D.jpg?dl=0
   
   Valid 40MB image:
   https://www.dropbox.com/s/cnxykbcvkbc2k1k/Airbus_Pleiades_50cm_8bit_RGB_Yogyakarta.jpg?dl=0
   
   I would like to move forward with the generic OutOfMemoryError as a catch all exception
within this Pull Request, as it solves a high impact error (corrupt images crashing the entire
Cordova app). Later, if/when a more accurate exception is found, it can be applied as an enhanced
exception.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Importing corrupt images using the Camera plugin crashes the app
> ----------------------------------------------------------------
>
>                 Key: CB-13415
>                 URL: https://issues.apache.org/jira/browse/CB-13415
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-camera
>         Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>            Reporter: Shemrick Flannigan
>            Priority: Critical
>              Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the Cordova app which
uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error message relaying
the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app | https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner class to
prevent an app crash | https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes]

> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera plugin, such
as:
> #* Yelp mobile app
> #* Slack mobile app



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message