cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X
Date Sun, 07 Jan 2018 12:50:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315239#comment-16315239
] 

ASF GitHub Bot commented on CB-13396:
-------------------------------------

jcesarmobile commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355820652
 
 
   People here is talking about 2 different issues, this one is about incorrect sizing when
transitioning from the storyboard to the plugin screen and seems to be fixed, so this PR might
not be necessary. The other problem is not reported (or I couldn't find it), but splash screen
doesn't work fine on iPhone X when NOT using storyboard, I'm about to report it and fix it.

   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> --------------------------------------------------------
>
>                 Key: CB-13396
>                 URL: https://issues.apache.org/jira/browse/CB-13396
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-splashscreen
>         Environment: iOS 11 / iPhone X
>            Reporter: Ken Mickles
>              Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into account, causing
the image size to change when CDVLaunchScreen.storyboard transitions to the CDVSplashScreen
image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message