cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12218) inconsistent null handling between EVAL and ONLINE bridge modes
Date Tue, 02 Jan 2018 03:57:02 GMT

    [ https://issues.apache.org/jira/browse/CB-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307667#comment-16307667
] 

ASF GitHub Bot commented on CB-12218:
-------------------------------------

codecov-io commented on issue #425: CB-12218: (android) Fix consistency of null result message
URL: https://github.com/apache/cordova-android/pull/425#issuecomment-354700133
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/425?src=pr&el=h1) Report
   > Merging [#425](https://codecov.io/gh/apache/cordova-android/pull/425?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/cordova-android/commit/a24ba41eda558c7a6a5f611173e8ebb837c6861c?src=pr&el=desc)
will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/425/graphs/tree.svg?token=q14nMf6C5a&src=pr&height=150&width=650)](https://codecov.io/gh/apache/cordova-android/pull/425?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #425   +/-   ##
   =======================================
     Coverage   43.91%   43.91%           
   =======================================
     Files          17       17           
     Lines        1710     1710           
     Branches      317      317           
   =======================================
     Hits          751      751           
     Misses        959      959
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/425?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/425?src=pr&el=footer).
Last update [a24ba41...45a7b90](https://codecov.io/gh/apache/cordova-android/pull/425?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> inconsistent null handling between EVAL and ONLINE bridge modes
> ---------------------------------------------------------------
>
>                 Key: CB-12218
>                 URL: https://issues.apache.org/jira/browse/CB-12218
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android
>    Affects Versions: 6.0.0
>         Environment: Android
>            Reporter: Alan Kinzie
>            Assignee: Joe Bowser
>         Attachments: CB12218.zip
>
>
> If the Android native code invokes the success callback like this:
> callbackContext.success(null);
> then the value given to the javascript callback changes depending on the bridge type
used.
> If the ONLINE_EVENT type is used, then null will be passed to the javascript callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be true
> result === "" // will be false
> If the EVAL_BRIDGE type is used, then an empty string will be passed to the javascript
callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be false
> result === "" // will be true
> The value of the parameter given to the success callback should not change depending
on the bridge type.  Since ONLINE_EVENT was the default before cordova android 6.0.0, I am
inclined to think the ONLINE bridge is doing the correct behaviour.  Also, converting null
to an empty string loses information.  Therefore I think the EVAL mode should to be changed
to be consistent with the ONLINE mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message