Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 13 Dec 2017 15:51:00 +0000 (UTC)
From: "Martin Birkby (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13124691.1513176175000.449800.1513180260331@Atlassian.JIRA>
In-Reply-To: <JIRA.13124691.1513176175000@Atlassian.JIRA>
References: <JIRA.13124691.1513176175000@Atlassian.JIRA> <JIRA.13124691.1513176175560@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-13676) InAppBrowser event.url is always
 lowercase
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 13 Dec 2017 15:51:08 -0000


    [ https://issues.apache.org/jira/browse/CB-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289419#comment-16289419 ] 

Martin Birkby commented on CB-13676:
------------------------------------

I've just made a mock up of this scenario using a mock oath server and the problem doesn't seem to occur in that. Not sure where this issue is coming from but it doesn't appear to be from the InAppBrowser itself. Using the original OAuth server case is maintained when returning the redirect to normal browser but not when it is returning it to InAppBrowser via the event url. I think this needs more investigation on my part. I'm sure it's not event.url causing the issue for me at least.

Apologies for taking up your time. Please close this issue, will report back once I've tracked down what is changing the case! Sorry!

> InAppBrowser event.url is always lowercase
> ------------------------------------------
>
>                 Key: CB-13676
>                 URL: https://issues.apache.org/jira/browse/CB-13676
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-inappbrowser
>         Environment: osx 10.13, xcode 9.2, ios 11.2, cordova-ios@4.5.1, cordova-plugin-device@1.1.4, cordova-plugin-inappbrowser@1.7.2, cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1
>            Reporter: Martin Birkby
>
> Hi,
> Trying to implement OAuth for a custom OAuth provider. The token that is returned contains Base64 encoded information which is lost as the event.url from the InAppBrowser amends the redirect url to lowercase. In this case the redirect url has ;token=<token> appended to it. The below code replicates...
> {code}
> public secureDataLogin(): Promise<any> {
>       return new Promise(function(resolve, reject) {
>           let csrf: string = uuid.v4();
>           var url = 'http://111.111.11.111:8080/auth/oauth/2' + '?response_type=token&csrf=' + csrf + '&redirect_uri=' +  'http://www.google.com' + '&scope=profile&client_id=a1aaaaaa-123a-132a-1a11-ab12345678ab';
>           var browserRef = window.cordova.InAppBrowser.open(url, "_blank", "location=no");
>           browserRef.addEventListener("loadstart", (event) => {
>               if ((event.url).indexOf('http://www.google.com') === 0) {
>                   browserRef.removeEventListener("exit", (event) => {});
>                   browserRef.close();
>                   
>                   // would decode and process the token data here
>                   console.log(event.url);
>               }
>           });
>           browserRef.addEventListener("loaderror", (event) => {
>             console.log('*ERROR*' + event.type + ' - ' + event.message);
>           });
>           browserRef.addEventListener("exit", function(event) {
>             console.log("Browser exit called");
>           });
>       });
>   }
> {code}
> Cheers
> Martin


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org