cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Piotrowski (Sujan) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13676) InAppBrowser event.url is always lowercase
Date Wed, 13 Dec 2017 15:33:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289393#comment-16289393
] 

Jan Piotrowski (Sujan) commented on CB-13676:
---------------------------------------------

Hm, any idea how to make a repro of this a bit simpler? I don't really want to build a OAuth
backend just to replicate this ;) 
One could probably use something like bit.ly to "simulate" the login and redirect to such
a URL. 
Could you please create a new, minimal reproduction app with `cordova create` that only includes
the relevant code and put it on Github?

Please also confirm this happens with the most recent `cordova-ios` version (4.5.4 I think)
and without `cordova-plugin-ionic-webview`, to exclude both as a contributing factor. Thanks.

> InAppBrowser event.url is always lowercase
> ------------------------------------------
>
>                 Key: CB-13676
>                 URL: https://issues.apache.org/jira/browse/CB-13676
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-inappbrowser
>         Environment: osx 10.13, xcode 9.2, ios 11.2, cordova-ios@4.5.1, cordova-plugin-device@1.1.4,
cordova-plugin-inappbrowser@1.7.2, cordova-plugin-ionic-webview@1.1.16, cordova-plugin-whitelist@1.3.1
>            Reporter: Martin Birkby
>
> Hi,
> Trying to implement OAuth for a custom OAuth provider. The token that is returned contains
Base64 encoded information which is lost as the event.url from the InAppBrowser amends the
redirect url to lowercase. In this case the redirect url has ;token=<token> appended
to it. The below code replicates...
> {code}
> public secureDataLogin(): Promise<any> {
>       return new Promise(function(resolve, reject) {
>           let csrf: string = uuid.v4();
>           var url = 'http://111.111.11.111:8080/auth/oauth/2' + '?response_type=token&csrf='
+ csrf + '&redirect_uri=' +  'http://www.google.com' + '&scope=profile&client_id=a1aaaaaa-123a-132a-1a11-ab12345678ab';
>           var browserRef = window.cordova.InAppBrowser.open(url, "_blank", "location=no");
>           browserRef.addEventListener("loadstart", (event) => {
>               if ((event.url).indexOf('http://www.google.com') === 0) {
>                   browserRef.removeEventListener("exit", (event) => {});
>                   browserRef.close();
>                   
>                   // would decode and process the token data here
>                   console.log(event.url);
>               }
>           });
>           browserRef.addEventListener("loaderror", (event) => {
>             console.log('*ERROR*' + event.type + ' - ' + event.message);
>           });
>           browserRef.addEventListener("exit", function(event) {
>             console.log("Browser exit called");
>           });
>       });
>   }
> {code}
> Cheers
> Martin



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message