cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13673) Remove deprecated platforms from screen orientation plugin
Date Wed, 13 Dec 2017 05:46:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288751#comment-16288751
] 

ASF GitHub Bot commented on CB-13673:
-------------------------------------

purplecabbage closed pull request #26: CB-13673 : Removed deprecated platforms
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/26
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index e295d91..7252761 100644
--- a/README.md
+++ b/README.md
@@ -23,7 +23,7 @@
 
 # Cordova Screen Orientation Plugin
 
-Cordova plugin to set/lock the screen orientation in a common way for iOS, Android, WP8 and
Blackberry 10.  This plugin is based on [Screen Orientation API](http://www.w3.org/TR/screen-orientation/)
so the api matches the current spec.
+Cordova plugin to set/lock the screen orientation in a common way for iOS and Android. This
plugin is based on [Screen Orientation API](http://www.w3.org/TR/screen-orientation/) so the
api matches the current spec.
 
 The plugin adds the following to the screen object (`window.screen`):
 
@@ -113,17 +113,6 @@ screen.orientation.onchange = function(){console.log(screen.orientation.type);
 
 The __screen.orientation__ property will not update when the phone is [rotated 180 degrees](http://www.quirksmode.org/dom/events/orientationchange.html).
 
-## BB10 Notes
-
-Wraps the com.blackberry.app plugin functions, auto installed as a dependancy.
-
-## WP8 Notes
-
-Windows phone does not support specification or primary and secondary orientations.  If called
with a specific orientation the plugin will just apply the landscape or portait orientation.
-
-## W8.1 Notes
-
-Windows 8.1 Applicaitons (runtime/metro applications) will only display orientation changes
if the device has some sort of accelerometer.  The internal state of the "orientation" will
still be kept, but the actual screen won't rotate unless the device supports it.
 
 # Legacy Changelog
 
diff --git a/package.json b/package.json
index 8d7fcf4..4304dea 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-screen-orientation",
-  "version": "2.0.3-dev",
+  "version": "3.0.0-dev",
   "description": "Adds Screen Orientation API lock and unlock functions to the global screen
object in android, iOS, WP8, W8.1, and BB10.",
   "repository": {
     "type": "git",
@@ -17,8 +17,7 @@
     "id": "cordova-plugin-screen-orientation",
     "platforms": [
       "android",
-      "ios",
-      "wp8"
+      "ios"
     ]
   },
   "keywords": [
diff --git a/plugin.xml b/plugin.xml
index 1da2cb5..33d6b84 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -18,9 +18,9 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
     id="cordova-plugin-screen-orientation"
-    version="2.0.3-dev">
+    version="3.0.0-dev">
     <name>Screen Orientation</name>
-    <description>Adds Screen Orientation API lock and unlock functions to the global
screen object in android, iOS, WP8, W8.1, and BB10.</description>
+    <description>Adds Screen Orientation API lock and unlock functions to the global
screen object in android and iOS.</description>
     <license>Apache 2.0</license>
 
     <engines>
@@ -56,23 +56,4 @@
 
     </platform>
 
-    <platform name="blackberry10">
-        <dependency id="com.blackberry.app" />
-        <config-file target="www/config.xml" parent="/widget">
-            <feature name="net.yoik.cordova.plugins.screenorientation" value="net.yoik.cordova.plugins.screenorientation"
/>
-        </config-file>
-        <js-module src="www/screenorientation.bb10.js" name="screenorientation.bb10">
-            <merges target="cordova.plugins.screenorientation" />
-        </js-module>
-        <dependency id="es6-promise-plugin" version="^4.1.0"/>
-    </platform>
-
-    <platform name="windows">
-        <js-module src="src/windows/CDVOrientationProxy.js" name="CDVOrientationProxy">
-            <merges target="" />
-        </js-module>
-    </platform>
-
-
-
 </plugin>
diff --git a/src/windows/CDVOrientationProxy.js b/src/windows/CDVOrientationProxy.js
deleted file mode 100644
index 7f36b49..0000000
--- a/src/windows/CDVOrientationProxy.js
+++ /dev/null
@@ -1,62 +0,0 @@
-/*
- *
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
-*/
-
-var DisplayInfo = Windows.Graphics.Display.DisplayInformation;
-var Orientations = Windows.Graphics.Display.DisplayOrientations;
-
-if (!window.Promise) {
-    window.Promise = WinJS.Promise;
-}
-
-module.exports = {
-    screenOrientation: function (win, fail, args) {
-        //console.log("screenOrientation proxy called with " + args);
-
-        try {
-            var prefOrients = args[0];
-            var winPrefs = 0;
-
-            if (prefOrients & 1) { // UIInterfaceOrientationPortrait
-                winPrefs = winPrefs |  Orientations.portrait;
-            }
-            if (prefOrients & 2) { // UIInterfaceOrientationPortraitUpsideDown
-                winPrefs = winPrefs | Orientations.portraitFlipped;
-            }
-            if(prefOrients & 4) { // UIInterfaceOrientationLandscapeLeft
-                winPrefs = winPrefs | Orientations.landscape;
-            }
-            if (prefOrients & 8) { // UIInterfaceOrientationLandscapeRight
-                winPrefs = winPrefs | Orientations.landscapeFlipped;
-            }
-            setTimeout(function () {
-                DisplayInfo.autoRotationPreferences = winPrefs;
-                win();
-            }, 0);
-        }
-        catch (err) {
-            console.log("error :: " + err);
-            fail();
-        }
-
-    }
-};
-
-require("cordova/exec/proxy").add("CDVOrientation", module.exports);
diff --git a/www/screenorientation.bb10.js b/www/screenorientation.bb10.js
deleted file mode 100644
index eef4bca..0000000
--- a/www/screenorientation.bb10.js
+++ /dev/null
@@ -1,34 +0,0 @@
-/*
- *
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
-*/
-
-var screenOrientation = {};
-
-screenOrientation.setOrientation = function(orientation) {
-    if (blackberry.app) {
-        if (orientation === 'unlocked') {
-            blackberry.app.unlockOrientation();
-        } else {
-            blackberry.app.lockOrientation(orientation);
-        }
-    }
-};
-
-module.exports = screenOrientation;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove deprecated platforms from screen orientation plugin
> ----------------------------------------------------------
>
>                 Key: CB-13673
>                 URL: https://issues.apache.org/jira/browse/CB-13673
>             Project: Apache Cordova
>          Issue Type: Task
>            Reporter: Vishal Mishra
>            Assignee: Vishal Mishra
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message