cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13672) Remove multiple exclusion of js-module in vibration plugin
Date Tue, 12 Dec 2017 20:40:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288237#comment-16288237
] 

ASF GitHub Bot commented on CB-13672:
-------------------------------------

maverickmishra closed pull request #61: CB-13672 : Remove multiple inclusion of js-module
URL: https://github.com/apache/cordova-plugin-vibration/pull/61
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/plugin.xml b/plugin.xml
index 8a88502..d45531e 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -30,11 +30,6 @@
     <repo>https://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration.git</repo>
     <issue>https://issues.apache.org/jira/browse/CB/component/12320639</issue>
 
-    <js-module src="www/vibration.js" name="notification">
-        <merges target="navigator.notification" />
-        <merges target="navigator" />
-    </js-module>
-
     <!-- firefoxos -->
     <platform name="firefoxos">
         <config-file target="www/config.xml" parent="/*">


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove multiple exclusion of js-module in vibration plugin
> ----------------------------------------------------------
>
>                 Key: CB-13672
>                 URL: https://issues.apache.org/jira/browse/CB-13672
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Vishal Mishra
>            Assignee: Vishal Mishra
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message