cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.
Date Thu, 07 Dec 2017 16:00:01 GMT

    [ https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282052#comment-16282052
] 

ASF GitHub Bot commented on CB-13641:
-------------------------------------

janpio commented on a change in pull request #244: CB-13641: (windows) allow for transparent
splash screen background co…
URL: https://github.com/apache/cordova-windows/pull/244#discussion_r155562627
 
 

 ##########
 File path: cordova-js-src/splashscreen.js
 ##########
 @@ -212,7 +215,7 @@ function exitFullScreen() {
 // Make title bg color match splashscreen bg color
 function colorizeTitleBar() {
     var appView = Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
-    if (isWin10UWP) {
+    if (isWin10UWP && (typeof titleBgColor !== 'undefined')) {
 
 Review comment:
   no nicer way to do this but then to check for undefined?
   took some time to understand what is going on here, especially with the `titleInitialBgColor
` that depends on this one

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -------------------------------------------------------------------------
>
>                 Key: CB-13641
>                 URL: https://issues.apache.org/jira/browse/CB-13641
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-windows
>    Affects Versions: cordova@7.0.0
>         Environment: Windows 10.
>            Reporter: Terence Bandoian
>            Priority: Trivial
>              Labels: newbie
>             Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, the background
color is expected to be a hex value and values longer than seven characters are spliced to
remove the alpha channel.  The configured value could be checked for the value 'transparent'
and, in that case, not spliced.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message