cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13562) Asset tag creates a directory with same name of targeted file
Date Wed, 06 Dec 2017 06:42:01 GMT

    [ https://issues.apache.org/jira/browse/CB-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279729#comment-16279729
] 

ASF subversion and git services commented on CB-13562:
------------------------------------------------------

Commit 31070d9b2f376e601fabbb0da836dcf8e5212011 in cordova-browser's branch refs/heads/master
from [~auso]
[ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=31070d9 ]

Merge pull request #48 from audreyso/CB-13562

CB-13562 : fixed asset tag when adding push plugin to browser

CB-13614 Create file path before copying asset

Fixes a bug that prevented copying over plugin assets that were nested in folders by creating
a directory path before the copy command.

CB-13614 Allow assets with a path to copy over correctly.

CB-13614 Remove commented out code.


> Asset tag creates a directory with same name of targeted file
> -------------------------------------------------------------
>
>                 Key: CB-13562
>                 URL: https://issues.apache.org/jira/browse/CB-13562
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-browser
>    Affects Versions: 5.0.1
>            Reporter: Simon MacDonald
>            Assignee: Jesse MacFadyen
>              Labels: reproduced, triaged
>
> Asset tag appears to be broken in the browser platform. According to the docs at http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#asset
when you add an asset tag like:
> {code:xml}
> <asset src="www/foo.js" target="foo.js" />
> {code}
> it should copy www/foo.js to platforms/browser/www/foo.js but instead it creates a subdirectory
called foo.js and the full path to the file is platforms/browser/www/foo.js/foo.js.
> If you want to duplicate this issue please create a new project then:
> cordova platform add browser@5.0.1
> cordova plugin add phonegap-plugin-push
> cordova build browser
> then you will see that platforms/browser/www/ServiceWorker.js/ServiceWorker.js exists
when it should be platforms/browser/www/ServiceWorker.js.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message