Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 29 Nov 2017 19:26:01 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13112285.1509026107000.348069.1511983561803@Atlassian.JIRA>
In-Reply-To: <JIRA.13112285.1509026107000@Atlassian.JIRA>
References: <JIRA.13112285.1509026107000@Atlassian.JIRA> <JIRA.13112285.1509026107795@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-13498) (inappbrowser) Add closebutton option
 for ios
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 29 Nov 2017 19:26:10 -0000


    [ https://issues.apache.org/jira/browse/CB-13498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271394#comment-16271394 ] 

ASF GitHub Bot commented on CB-13498:
-------------------------------------

jaapjanfrans commented on issue #247: CB-13498 added closebutton option for ios
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/247#issuecomment-347968656
 
 
   Hey thanks for chiming in!
   
   **Why would a developer want to have an inappbrowser window with no close button?**
   Simple, because the inappbrowser should not be closed in the app I'm building
   **As a user of the app, how would you close the inappbrowser?**
   The user is not supposed to close it :-) The app is basically wrapping a web app using the inappbrowser. It runs it's own javascriptcontext in the main webview of the app. The main webview handles push notifications, log in functionallity, sharing of content to the application from other apps on the device, the inappbrowser show the web app. The user does al his/her work in the web app.
   **Why would this be an iOS specific feature only?**
   On android, we just do not show the toolbar at all so the problem does not exist there. But on ios, we want to retain the forward/backwards control of the toolbar because ios has no backbutton in it's ui. So we want to have a toolbar with just the navigational controls. current situation on ios is that you get both, the nav controls and the close button.  
   
   **To me this seems like a very specific use case that doesn't warrant adding it back to the main plugin repo.**
   Of course it's a specific use case, i won't argue with that. But why not offer the option when it's so easy to implement. Why limit ourselves to an 'all or nothing' toolbar :-)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> (inappbrowser) Add closebutton option for ios
> ---------------------------------------------
>
>                 Key: CB-13498
>                 URL: https://issues.apache.org/jira/browse/CB-13498
>             Project: Apache Cordova
>          Issue Type: New Feature
>            Reporter: Jaap-Jan
>
> On ios the toolbar has a close button and back/next buttons. You can disable the entire toolbar, but not disable the close button only.
> If a closebutton option is support, you can have a toolbar that only has the navigational buttons. 
> I needed this for a project that needs to keep the inappbrowser opened at all times (so a close button should not be shown)  but also requires to have navigational buttons of the toolbar.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org