Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 27 Nov 2017 15:45:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13107060.1507150576000.324821.1511797500617@Atlassian.JIRA>
In-Reply-To: <JIRA.13107060.1507150576000@Atlassian.JIRA>
References: <JIRA.13107060.1507150576000@Atlassian.JIRA> <JIRA.13107060.1507150576213@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-13396) Splash screen images are resized
 incorrectly on iPhone X
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 27 Nov 2017 15:45:05 -0000


    [ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266957#comment-16266957 ] 

ASF GitHub Bot commented on CB-13396:
-------------------------------------

EternallLight commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347222370
 
 
   @Drewster727 
   
   I started with standard sizes as listen in the documentation: 
   
   2x* | universal | any | any | 2732x2732 | Default@2x~universal~anyany.png
   2x | universal | com | any | 1278x2732 | Default@2x~universal~comany.png
   2x | universal | com | com | 1334x750 | Default@2x~universal~comcom.png
   3x* | universal | any | any | 2208x2208 | Default@3x~universal~anyany.png
   3x | universal | any | com | 2208x1242 | Default@3x~universal~anycom.png
   3x | universal | com | any | 1242x2208 | Default@3x~universal~comany.png
   
   The reason why I didn't do this initially, is that for some reason it didn't work with another file path than specified in documentation (I had it available in resources/ios/splash, but they must be in res/screen/ios.
   
   I created all these images, put them in res/screen/ios, run `cordova prepare`, and they all appeared in Images.xassets/LaunchStoryboard as they're supposed to be, and the issue with iPhone X was gone.
   
   Note that you often need to re-install the app, on your phone or simulator in order to see the changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> --------------------------------------------------------
>
>                 Key: CB-13396
>                 URL: https://issues.apache.org/jira/browse/CB-13396
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-splashscreen
>         Environment: iOS 11 / iPhone X
>            Reporter: Ken Mickles
>              Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into account, causing the image size to change when CDVLaunchScreen.storyboard transitions to the CDVSplashScreen image.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org