Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 26 Nov 2017 16:21:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13107060.1507150576000.320011.1511713260066@Atlassian.JIRA>
In-Reply-To: <JIRA.13107060.1507150576000@Atlassian.JIRA>
References: <JIRA.13107060.1507150576000@Atlassian.JIRA> <JIRA.13107060.1507150576213@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-13396) Splash screen images are resized
 incorrectly on iPhone X
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 26 Nov 2017 16:21:06 -0000


    [ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266084#comment-16266084 ] 

ASF GitHub Bot commented on CB-13396:
-------------------------------------

Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347018801
 
 
   @myrsk thanks! Unfortunately that didn't fix my issue. Might be easier if I attach screenshots. My issue may be slightly different... I start out on the X with a correctly sized image, and then it changes to an incorrect sized image (no bars on top or bottom like other folks). 
   
   Right when the app starts up:
   <img width="434" alt="kcst_ok" src="https://user-images.githubusercontent.com/4528753/33241855-a7e5bc1a-d299-11e7-9edd-825f9408594a.png">
   
   A couple seconds after the above image, it switches to this:
   <img width="420" alt="kcst_bad" src="https://user-images.githubusercontent.com/4528753/33241857-ac4b51b6-d299-11e7-805f-d38d9de52112.png">
   
   I have debugged the CDVSplashScreen.m file and can't quite figure out what's causing this. I did add some code to detect the iPhoneX and force loading the -2643h splash file. When I did that I notice that instead of an incorrectly sized image, I get a white screen after my correctly sized image.
   
   I've also tried the cordova-ios nightly builds. Did not resolve my issue. 
   
   cordova-cli 7.1.0
   cordova-ios 4.5.4
   cordova-plugin-splashscreen 4.1.0
   
   Anyone have any ideas? I only see this symptom on the iPhone X

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> --------------------------------------------------------
>
>                 Key: CB-13396
>                 URL: https://issues.apache.org/jira/browse/CB-13396
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-splashscreen
>         Environment: iOS 11 / iPhone X
>            Reporter: Ken Mickles
>              Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into account, causing the image size to change when CDVLaunchScreen.storyboard transitions to the CDVSplashScreen image.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org