cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13610) Android default image assets are not compressed
Date Tue, 28 Nov 2017 18:36:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269225#comment-16269225
] 

ASF GitHub Bot commented on CB-13610:
-------------------------------------

infil00p closed pull request #418: CB-13610: Compress the default app assets
URL: https://github.com/apache/cordova-android/pull/418
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/project/res/drawable-land-hdpi/screen.png b/bin/templates/project/res/drawable-land-hdpi/screen.png
index a61e2b1a3..2d564f49c 100644
Binary files a/bin/templates/project/res/drawable-land-hdpi/screen.png and b/bin/templates/project/res/drawable-land-hdpi/screen.png
differ
diff --git a/bin/templates/project/res/drawable-land-ldpi/screen.png b/bin/templates/project/res/drawable-land-ldpi/screen.png
index f3934cdcc..c7eae7ede 100644
Binary files a/bin/templates/project/res/drawable-land-ldpi/screen.png and b/bin/templates/project/res/drawable-land-ldpi/screen.png
differ
diff --git a/bin/templates/project/res/drawable-land-mdpi/screen.png b/bin/templates/project/res/drawable-land-mdpi/screen.png
index a1b697c53..3bf1ec2e9 100644
Binary files a/bin/templates/project/res/drawable-land-mdpi/screen.png and b/bin/templates/project/res/drawable-land-mdpi/screen.png
differ
diff --git a/bin/templates/project/res/drawable-land-xhdpi/screen.png b/bin/templates/project/res/drawable-land-xhdpi/screen.png
index 79f2f0945..987a92462 100644
Binary files a/bin/templates/project/res/drawable-land-xhdpi/screen.png and b/bin/templates/project/res/drawable-land-xhdpi/screen.png
differ
diff --git a/bin/templates/project/res/drawable-land-xxhdpi/screen.png b/bin/templates/project/res/drawable-land-xxhdpi/screen.png
index 2f5683808..ef9fc7400 100644
Binary files a/bin/templates/project/res/drawable-land-xxhdpi/screen.png and b/bin/templates/project/res/drawable-land-xxhdpi/screen.png
differ
diff --git a/bin/templates/project/res/drawable-land-xxxhdpi/screen.png b/bin/templates/project/res/drawable-land-xxxhdpi/screen.png
index ff6c13c28..8f9a458e1 100644
Binary files a/bin/templates/project/res/drawable-land-xxxhdpi/screen.png and b/bin/templates/project/res/drawable-land-xxxhdpi/screen.png
differ
diff --git a/bin/templates/project/res/drawable-port-hdpi/screen.png b/bin/templates/project/res/drawable-port-hdpi/screen.png
index 5d6a28a82..5875561d3 100644
Binary files a/bin/templates/project/res/drawable-port-hdpi/screen.png and b/bin/templates/project/res/drawable-port-hdpi/screen.png
differ
diff --git a/bin/templates/project/res/drawable-port-ldpi/screen.png b/bin/templates/project/res/drawable-port-ldpi/screen.png
index 65ad163ab..725420620 100644
Binary files a/bin/templates/project/res/drawable-port-ldpi/screen.png and b/bin/templates/project/res/drawable-port-ldpi/screen.png
differ
diff --git a/bin/templates/project/res/drawable-port-mdpi/screen.png b/bin/templates/project/res/drawable-port-mdpi/screen.png
index ea1569359..9034b68fd 100644
Binary files a/bin/templates/project/res/drawable-port-mdpi/screen.png and b/bin/templates/project/res/drawable-port-mdpi/screen.png
differ
diff --git a/bin/templates/project/res/drawable-port-xhdpi/screen.png b/bin/templates/project/res/drawable-port-xhdpi/screen.png
index c2e804217..95dc8d849 100644
Binary files a/bin/templates/project/res/drawable-port-xhdpi/screen.png and b/bin/templates/project/res/drawable-port-xhdpi/screen.png
differ
diff --git a/bin/templates/project/res/drawable-port-xxhdpi/screen.png b/bin/templates/project/res/drawable-port-xxhdpi/screen.png
index 9c7df083d..9b6bfe4a8 100644
Binary files a/bin/templates/project/res/drawable-port-xxhdpi/screen.png and b/bin/templates/project/res/drawable-port-xxhdpi/screen.png
differ
diff --git a/bin/templates/project/res/drawable-port-xxxhdpi/screen.png b/bin/templates/project/res/drawable-port-xxxhdpi/screen.png
index 68c799896..ec655cde1 100644
Binary files a/bin/templates/project/res/drawable-port-xxxhdpi/screen.png and b/bin/templates/project/res/drawable-port-xxxhdpi/screen.png
differ
diff --git a/bin/templates/project/res/mipmap-hdpi/icon.png b/bin/templates/project/res/mipmap-hdpi/icon.png
index 4d2763448..538426124 100644
Binary files a/bin/templates/project/res/mipmap-hdpi/icon.png and b/bin/templates/project/res/mipmap-hdpi/icon.png
differ
diff --git a/bin/templates/project/res/mipmap-ldpi/icon.png b/bin/templates/project/res/mipmap-ldpi/icon.png
index cd5032a4f..c5fcaeb64 100644
Binary files a/bin/templates/project/res/mipmap-ldpi/icon.png and b/bin/templates/project/res/mipmap-ldpi/icon.png
differ
diff --git a/bin/templates/project/res/mipmap-mdpi/icon.png b/bin/templates/project/res/mipmap-mdpi/icon.png
index e79c6062c..a18167be1 100644
Binary files a/bin/templates/project/res/mipmap-mdpi/icon.png and b/bin/templates/project/res/mipmap-mdpi/icon.png
differ
diff --git a/bin/templates/project/res/mipmap-xhdpi/icon.png b/bin/templates/project/res/mipmap-xhdpi/icon.png
index ec7ffbfbd..9e3eec364 100644
Binary files a/bin/templates/project/res/mipmap-xhdpi/icon.png and b/bin/templates/project/res/mipmap-xhdpi/icon.png
differ
diff --git a/bin/templates/project/res/mipmap-xxhdpi/icon.png b/bin/templates/project/res/mipmap-xxhdpi/icon.png
index 38c2bf5e1..a56928965 100644
Binary files a/bin/templates/project/res/mipmap-xxhdpi/icon.png and b/bin/templates/project/res/mipmap-xxhdpi/icon.png
differ
diff --git a/bin/templates/project/res/mipmap-xxxhdpi/icon.png b/bin/templates/project/res/mipmap-xxxhdpi/icon.png
index 53e57538d..3c322f2ea 100644
Binary files a/bin/templates/project/res/mipmap-xxxhdpi/icon.png and b/bin/templates/project/res/mipmap-xxxhdpi/icon.png
differ


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Android default image assets are not compressed
> -----------------------------------------------
>
>                 Key: CB-13610
>                 URL: https://issues.apache.org/jira/browse/CB-13610
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Darryl Pogue
>            Assignee: Darryl Pogue
>            Priority: Minor
>
> The default splash screen and app icon images in Cordova-Android account for 7MB, and
get bundled into the apk with minimal compression.
> Running them through pngquant and zopflipng results in assets that are only 1.7MB, which
is a savings of 75%



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message